Bug 204838

Summary: Python 3: Add support in webkitpy.tool
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, aperez, ap, commit-queue, ews-watchlist, glenn, jbedard, mcatanzaro, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=184986
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2019-12-03 21:58:18 PST
This supports running webkit-patch with Python 3.
Attachments
Patch (56.52 KB, patch)
2019-12-03 22:29 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (4.81 KB, patch)
2019-12-05 09:00 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (5.29 KB, patch)
2019-12-05 09:02 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (5.88 KB, patch)
2019-12-06 13:57 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-12-03 22:29:26 PST
Created attachment 384788 [details] Patch
WebKit Commit Bot
Comment 2 2019-12-04 16:10:49 PST
Comment on attachment 384788 [details] Patch Clearing flags on attachment: 384788 Committed r253128: <https://trac.webkit.org/changeset/253128>
WebKit Commit Bot
Comment 3 2019-12-04 16:10:51 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-12-04 16:11:24 PST
<rdar://problem/57645975>
Jonathan Bedard
Comment 5 2019-12-05 09:00:35 PST
Reopening to attach new patch.
Jonathan Bedard
Comment 6 2019-12-05 09:00:36 PST
Created attachment 384910 [details] Patch
Jonathan Bedard
Comment 7 2019-12-05 09:02:37 PST
Created attachment 384911 [details] Patch
Jonathan Bedard
Comment 8 2019-12-05 09:04:19 PST
(In reply to Jonathan Bedard from comment #7) > Created attachment 384911 [details] > Patch Tried uploading a patch with Python 3, hit a few bumps. This is what I needed for webkit-patch upload.
Stephanie Lewis
Comment 9 2019-12-05 15:24:53 PST
Comment on attachment 384911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384911&action=review > Tools/Scripts/webkit-patch:45 > +# If our str type isn't unicode, we need to standardize output format why remove all the comments?
Jonathan Bedard
Comment 10 2019-12-05 15:36:54 PST
(In reply to Stephanie Lewis from comment #9) > Comment on attachment 384911 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384911&action=review > > > Tools/Scripts/webkit-patch:45 > > +# If our str type isn't unicode, we need to standardize output format > > why remove all the comments? I can put them back, but they weren't super helpful and not applicable to Python 3. We're likely going to be removing them once we are only Python 3 anyways.
Stephanie Lewis
Comment 11 2019-12-06 13:46:07 PST
Comment on attachment 384911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384911&action=review >>> Tools/Scripts/webkit-patch:45 >>> +# If our str type isn't unicode, we need to standardize output format >> >> why remove all the comments? > > I can put them back, but they weren't super helpful and not applicable to Python 3. We're likely going to be removing them once we are only Python 3 anyways. I think Saying why 2.7 needs a forgiving utf8 writer is important to explain why this class exists. And the bug number this code is solving is useful too
Jonathan Bedard
Comment 12 2019-12-06 13:57:30 PST
Created attachment 385040 [details] Patch
Jonathan Bedard
Comment 13 2019-12-06 13:58:20 PST
(In reply to Stephanie Lewis from comment #11) > Comment on attachment 384911 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384911&action=review > > >>> Tools/Scripts/webkit-patch:45 > >>> +# If our str type isn't unicode, we need to standardize output format > >> > >> why remove all the comments? > > > > I can put them back, but they weren't super helpful and not applicable to Python 3. We're likely going to be removing them once we are only Python 3 anyways. > > I think Saying why 2.7 needs a forgiving utf8 writer is important to explain > why this class exists. And the bug number this code is solving is useful too Ok, added back in the comments.
WebKit Commit Bot
Comment 14 2019-12-06 15:00:28 PST
Comment on attachment 385040 [details] Patch Clearing flags on attachment: 385040 Committed r253222: <https://trac.webkit.org/changeset/253222>
WebKit Commit Bot
Comment 15 2019-12-06 15:00:30 PST
All reviewed patches have been landed. Closing bug.
Jonathan Bedard
Comment 16 2019-12-06 16:11:49 PST
Committed r253230: <https://trac.webkit.org/changeset/253230>
Note You need to log in before you can comment on or make changes to this bug.