Bug 204335

Summary: Rename AbstractEventLoop to EventLoop and move to its own cpp file
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, commit-queue, dbates, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kangil.han, koivisto, macpherson, menard, philipj, sergio, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 204263    
Bug Blocks: 203667, 204042    
Attachments:
Description Flags
Cleanup
none
Cleanup
none
Cleanup koivisto: review+

Ryosuke Niwa
Reported 2019-11-18 17:47:33 PST
Now that the much of event loop implementation moved to AbstractEventLoop in r252607, move to its own file.
Attachments
Cleanup (20.83 KB, patch)
2019-11-18 17:57 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Cleanup (37.30 KB, patch)
2019-11-18 17:59 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Cleanup (37.30 KB, patch)
2019-11-18 18:03 PST, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-11-18 17:57:15 PST
Created attachment 383823 [details] Cleanup
Ryosuke Niwa
Comment 2 2019-11-18 17:59:54 PST
Created attachment 383825 [details] Cleanup
Ryosuke Niwa
Comment 3 2019-11-18 18:03:30 PST
Created attachment 383828 [details] Cleanup
Ryosuke Niwa
Comment 4 2019-11-18 18:05:05 PST
Comment on attachment 383828 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=383828&action=review > Source/WebCore/dom/EventLoop.h:62 > +class AbstractEventLoop : public RefCounted<AbstractEventLoop>, public CanMakeWeakPtr<AbstractEventLoop> { Note that this is the old file content for svn mv. See below for the actual diff.
Ryosuke Niwa
Comment 5 2019-11-18 18:06:37 PST
Comment on attachment 383828 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=383828&action=review >> Source/WebCore/dom/EventLoop.h:62 >> +class EventLoop : public RefCounted<EventLoop>, public CanMakeWeakPtr<EventLoop> { > > Note that this is the old file content for svn mv. See below for the actual diff. Huh, I guess review tool can't tell to which file the comment is added. I meant to add this to the file above which shows the original content of the file.
Ryosuke Niwa
Comment 6 2019-11-19 00:32:27 PST
Comment on attachment 383828 [details] Cleanup Thanks for review!
Ryosuke Niwa
Comment 7 2019-11-19 00:33:50 PST
Comment on attachment 383828 [details] Cleanup Hold on, this isn’t go gonna work in CQ. Will land manually tomorrow.
Antti Koivisto
Comment 8 2019-11-19 00:34:36 PST
(In reply to Ryosuke Niwa from comment #4) > Note that this is the old file content for svn mv. See below for the actual > diff. How did you generate the diff? Git usually seems to produce nicer diffs for move/renames (see https://bugs.webkit.org/attachment.cgi?id=383806&action=review for example).
Ryosuke Niwa
Comment 9 2019-11-19 00:36:17 PST
(In reply to Antti Koivisto from comment #8) > (In reply to Ryosuke Niwa from comment #4) > > Note that this is the old file content for svn mv. See below for the actual > > diff. > > How did you generate the diff? Git usually seems to produce nicer diffs for > move/renames (see > https://bugs.webkit.org/attachment.cgi?id=383806&action=review for example). I did svn mv then modified the file. This used to work too but someone broke it some point and nobody fixed it.
Ryosuke Niwa
Comment 10 2019-11-19 13:57:54 PST
Committed r252646: <https://trac.webkit.org/changeset/252646>
Radar WebKit Bug Importer
Comment 11 2019-11-19 13:58:20 PST
<rdar://problem/57335190>
Note You need to log in before you can comment on or make changes to this bug.