Bug 203086

Summary: Deprecate ActiveDOMObject::canSuspendForDocumentSuspension()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, benjamin, calvaris, commit-queue, dbates, dino, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, graouts, gyuyoung.kim, hta, jer.noble, jsbell, kangil.han, koivisto, kondapallykalyan, macpherson, menard, mmaxfield, philipj, sergio, thorton, tommyw, toyoshim, webkit-bug-importer, youennf, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202293    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2019-10-17 09:20:30 PDT
Deprecate ActiveDOMObject::canSuspendForDocumentSuspension() as it is no longer acceptable to prevent a page from entering the back/forward cache.
Attachments
Patch (88.14 KB, patch)
2019-10-17 09:24 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-10-17 09:24:48 PDT
Created attachment 381196 [details] Patch
Antti Koivisto
Comment 2 2019-10-17 09:38:07 PDT
Comment on attachment 381196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381196&action=review > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:746 > +// FIXME: This should never prevent entering the back/forward cache. It might be good to file and link bugs for all these.
Chris Dumez
Comment 3 2019-10-17 09:39:08 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 381196 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381196&action=review > > > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:746 > > +// FIXME: This should never prevent entering the back/forward cache. > > It might be good to file and link bugs for all these. Agreed, will do this next.
Chris Dumez
Comment 4 2019-10-17 10:00:32 PDT
Comment on attachment 381196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381196&action=review >>> Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:746 >>> +// FIXME: This should never prevent entering the back/forward cache. >> >> It might be good to file and link bugs for all these. > > Agreed, will do this next. Ok, I mass-filed a bug for each remaining override and related all the bugs to https://bugs.webkit.org/show_bug.cgi?id=202293.
Geoffrey Garen
Comment 5 2019-10-17 10:33:30 PDT
Comment on attachment 381196 [details] Patch r=me
Chris Dumez
Comment 6 2019-10-17 10:35:34 PDT
Comment on attachment 381196 [details] Patch Clearing flags on attachment: 381196 Committed r251244: <https://trac.webkit.org/changeset/251244>
Chris Dumez
Comment 7 2019-10-17 10:35:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-10-17 10:36:12 PDT
<rdar://problem/56375664>
Note You need to log in before you can comment on or make changes to this bug.