Bug 202687

Summary: REGRESSION (Catalina) non-scrolling iframe prevents document scrolling
Product: WebKit Reporter: gerhard.preuss
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
Patch none

gerhard.preuss
Reported 2019-10-08 02:53:56 PDT
This is new as of Safari 13 on OSX. iFrames seem to trap/capture scroll events and prevent the document to scroll (trackpad/touch input). Reproduce: https://codepen.io/lipp/pen/LYYEEgd Expected behaviour: Page scrolls normal as if the iFrame were an image. Actual behaviour: Page is not scrollable when the (touch) input pointer is above the iFrame (green rect in example).
Attachments
Patch (7.49 KB, patch)
2020-01-13 16:30 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
gerhard.preuss
Comment 1 2019-10-08 03:04:04 PDT
Using the mouse wheel works. So "just" trackpad is affected.
Radar WebKit Bug Importer
Comment 2 2019-10-10 18:12:32 PDT
<rdar://problem/56176782>
Simon Fraser (smfr)
Comment 3 2019-10-10 18:15:59 PDT
I can reproduce. Possibly a latching issue.
Simon Fraser (smfr)
Comment 4 2019-10-12 11:36:06 PDT
EventHandler::platformCompleteWheelEvent() finds the non-scrollable iframe as the thing to latch to and thinks that we started scrolling on it.
Simon Fraser (smfr)
Comment 5 2019-10-12 12:36:41 PDT
I think the bug is that scrolledToEdgeInDominantDirection() doesn't consider scrollable="no" iframes.
Simon Fraser (smfr)
Comment 6 2020-01-13 16:30:01 PST
Created attachment 387590 [details] Patch
WebKit Commit Bot
Comment 7 2020-01-13 23:17:44 PST
The commit-queue encountered the following flaky tests while processing attachment 387590 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2020-01-13 23:18:19 PST
Comment on attachment 387590 [details] Patch Clearing flags on attachment: 387590 Committed r254497: <https://trac.webkit.org/changeset/254497>
WebKit Commit Bot
Comment 9 2020-01-13 23:18:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.