Bug 202620

Summary: [CSS Shadow Parts] Internal shadow pseudo elements should work with ::part
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149443    
Attachments:
Description Flags
patch
none
patch
none
patch none

Antti Koivisto
Reported 2019-10-06 03:09:24 PDT
::part(foo)::placeholder
Attachments
patch (11.06 KB, patch)
2019-10-06 06:08 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (11.15 KB, patch)
2019-10-06 06:39 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (11.52 KB, patch)
2019-10-07 06:58 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-10-06 06:08:44 PDT
Created attachment 380295 [details] patch
Antti Koivisto
Comment 2 2019-10-06 06:39:23 PDT
Created attachment 380297 [details] patch
Antti Koivisto
Comment 3 2019-10-07 06:58:15 PDT
Created attachment 380323 [details] patch
Ryosuke Niwa
Comment 4 2019-10-07 13:50:05 PDT
Comment on attachment 380323 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=380323&action=review > LayoutTests/ChangeLog:11 > + * TestExpectations: Can we add tests for ::before & ::after?
Antti Koivisto
Comment 5 2019-10-07 23:48:18 PDT
> Can we add tests for ::before & ::after? They are already tested by a WPT test (and unaffected by this patch). I'll land some more tests separately.
Ryosuke Niwa
Comment 6 2019-10-07 23:50:27 PDT
(In reply to Antti Koivisto from comment #5) > > Can we add tests for ::before & ::after? > > They are already tested by a WPT test (and unaffected by this patch). I'll > land some more tests separately. Nice!
WebKit Commit Bot
Comment 7 2019-10-08 00:31:44 PDT
Comment on attachment 380323 [details] patch Clearing flags on attachment: 380323 Committed r250817: <https://trac.webkit.org/changeset/250817>
WebKit Commit Bot
Comment 8 2019-10-08 00:31:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-10-08 00:32:16 PDT
<rdar://problem/56065249>
Note You need to log in before you can comment on or make changes to this bug.