Bug 202396

Summary: Queue events and promise resolution in RTCPeerConnection when suspended for page cache
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, ews-watchlist, ggaren, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202403    
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2019-10-01 03:32:20 PDT
Queue events and promise resolution in RTCPeerConnection when suspended for page cache. This is a preliminary patch to optimise page cache for pages with RTCPeerConnection.
Attachments
Patch (13.45 KB, patch)
2019-10-01 03:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.64 KB, patch)
2019-10-01 11:16 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-10-01 03:36:33 PDT
Created attachment 379886 [details] Patch
Chris Dumez
Comment 2 2019-10-01 09:29:03 PDT
Comment on attachment 379886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379886&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:632 > +void RTCPeerConnection::fireEvent(Ref<Event>&& event) I don't really like the name fireEvent(), I do not think it makes it clear what the difference with dispatchEvent() is. I suggest dispatchEventWhenPossible() or dispatchEventWhenAllowed()
youenn fablet
Comment 3 2019-10-01 11:16:04 PDT
Created attachment 379916 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-10-01 14:35:45 PDT
Comment on attachment 379916 [details] Patch for landing Clearing flags on attachment: 379916 Committed r250582: <https://trac.webkit.org/changeset/250582>
WebKit Commit Bot
Comment 5 2019-10-01 14:35:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-10-01 14:36:18 PDT
<rdar://problem/55890291>
Note You need to log in before you can comment on or make changes to this bug.