Bug 201300

Summary: Make NetworkConnectionToWebProcess keyed by its WebProcess identifier
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 201299    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Fix Wincairo none

youenn fablet
Reported 2019-08-29 06:03:33 PDT
Make NetworkConnectionToWebProcess keyed by their WebProcess identifier
Attachments
Patch (23.60 KB, patch)
2019-08-29 06:14 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (26.48 KB, patch)
2019-08-30 03:11 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (26.50 KB, patch)
2019-08-30 03:55 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fix Wincairo (27.46 KB, patch)
2019-09-01 23:06 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-08-29 06:14:06 PDT
Created attachment 377572 [details] Patch
youenn fablet
Comment 2 2019-08-30 03:11:44 PDT
Created attachment 377691 [details] Patch
youenn fablet
Comment 3 2019-08-30 03:55:17 PDT
Created attachment 377695 [details] Patch
Alex Christensen
Comment 4 2019-08-30 08:36:38 PDT
Comment on attachment 377695 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377695&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:389 > + return std::make_pair(socketPair.server, IPC::Attachment { socketPair.client }); You could use {} instead of std::make_pair > Source/WebKit/NetworkProcess/NetworkProcess.cpp:420 > + completionHandler({ }); WTF::null opt
youenn fablet
Comment 5 2019-09-01 23:01:39 PDT
(In reply to Alex Christensen from comment #4) > Comment on attachment 377695 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377695&action=review > > > Source/WebKit/NetworkProcess/NetworkProcess.cpp:389 > > + return std::make_pair(socketPair.server, IPC::Attachment { socketPair.client }); > > You could use {} instead of std::make_pair The function returns an Optional<std::pair> so we need to return a pair explicitly here.
youenn fablet
Comment 6 2019-09-01 23:06:48 PDT
Created attachment 377840 [details] Fix Wincairo
WebKit Commit Bot
Comment 7 2019-09-02 02:31:45 PDT
Comment on attachment 377840 [details] Fix Wincairo Clearing flags on attachment: 377840 Committed r249379: <https://trac.webkit.org/changeset/249379>
WebKit Commit Bot
Comment 8 2019-09-02 02:31:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-09-02 02:32:18 PDT
<rdar://problem/54945251>
Note You need to log in before you can comment on or make changes to this bug.