Bug 195960

Summary: Remove the SVG property tear off objects of SVGAnimatedPreserveAspectRatio
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 195949    
Bug Blocks: 191237, 196025    
Attachments:
Description Flags
Patch
none
Patch for review
none
Patch none

Said Abou-Hallawa
Reported 2019-03-19 12:32:02 PDT
This is very similar to https://bugs.webkit.org/show_bug.cgi?id=195949. The changes should be almost the same expect the animation function for SVGRect is additive while it is discrete for SVGPreserveAspectRatio.
Attachments
Patch (112.44 KB, patch)
2019-03-19 12:35 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch for review (70.21 KB, patch)
2019-03-19 12:38 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (70.12 KB, patch)
2019-03-19 18:22 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2019-03-19 12:35:12 PDT
Created attachment 365205 [details] Patch
Said Abou-Hallawa
Comment 2 2019-03-19 12:38:40 PDT
Created attachment 365208 [details] Patch for review
Simon Fraser (smfr)
Comment 3 2019-03-19 15:58:44 PDT
Comment on attachment 365208 [details] Patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=365208&action=review > Source/WebCore/ChangeLog:12 > + -- Define SVGAnimatedPreserveAspectRatio to be SVGAnimatedValueProperty< > + SVGPreserveAspectRatio>. > + > + -- Make SVGPreserveAspectRatio be derived form SVGValueProperty<S > + VGPreserveAspectRatioValue>. Bad wrapping. > Source/WebCore/svg/properties/SVGAnimatedPropertyAnimatorImpl.h:84 > + return std::unique_ptr<SVGAnimatedPreserveAspectRatioAnimator>(new SVGAnimatedPreserveAspectRatioAnimator(attributeName, animated, animationMode, calcMode, isAccumulated, isAdditive)); make_unique<>
Said Abou-Hallawa
Comment 4 2019-03-19 18:22:45 PDT
Created attachment 365279 [details] Patch
WebKit Commit Bot
Comment 5 2019-03-19 18:49:36 PDT
Comment on attachment 365279 [details] Patch Clearing flags on attachment: 365279 Committed r243185: <https://trac.webkit.org/changeset/243185>
WebKit Commit Bot
Comment 6 2019-03-19 18:49:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-03-19 18:50:22 PDT
<rdar://problem/49045550>
Note You need to log in before you can comment on or make changes to this bug.