Bug 193798

Summary: iOS: Split keyboard should not shrink visualViewport.height
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, simon.fraser, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170982    
Attachments:
Description Flags
Fixes the bug
thorton: review+
Test patch none

Ryosuke Niwa
Reported 2019-01-24 16:36:17 PST
When the user brings up split keyboard, we should treat it like a floating keyboard and not shrink the height of visualViewport.height. <rdar://problem/47504231>
Attachments
Fixes the bug (2.44 KB, patch)
2019-01-24 16:45 PST, Ryosuke Niwa 		thorton: review+
DetailsFormatted DiffDiff
Test patch (8.72 KB, patch)
2019-01-24 17:28 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-01-24 16:45:14 PST
Created attachment 360049 [details] Fixes the bug
Simon Fraser (smfr)
Comment 2 2019-01-24 17:24:09 PST
Comment on attachment 360049 [details] Fixes the bug Can we test this?
Ryosuke Niwa
Comment 3 2019-01-24 17:25:36 PST
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 360049 [details] > Fixes the bug > > Can we test this? As I explained in the change log, it's possible to split the keyboard using some SPI but there isn't a reliable way to reset the state if the test gets terminated prematurely. Then iPad Simulator will be forever hosed until someone fixes it. I don't think we want to take that kind of bot maintenance risk.
Ryosuke Niwa
Comment 4 2019-01-24 17:28:04 PST
Created attachment 360060 [details] Test patch Here's the patch to add test. It works but it can forever hose the iOS simulator with split keyboard...
Ryosuke Niwa
Comment 5 2019-01-24 18:53:29 PST
Committed r240466: <https://trac.webkit.org/changeset/240466>
Note You need to log in before you can comment on or make changes to this bug.