Bug 193767

Summary: [iPad] Initial test gardening
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193970
https://bugs.webkit.org/show_bug.cgi?id=193971
https://bugs.webkit.org/show_bug.cgi?id=193994
https://bugs.webkit.org/show_bug.cgi?id=194221
https://bugs.webkit.org/show_bug.cgi?id=194223
https://bugs.webkit.org/show_bug.cgi?id=194226
https://bugs.webkit.org/show_bug.cgi?id=194228
https://bugs.webkit.org/show_bug.cgi?id=194234
https://bugs.webkit.org/show_bug.cgi?id=194259
https://bugs.webkit.org/show_bug.cgi?id=194313
https://bugs.webkit.org/show_bug.cgi?id=194314
https://bugs.webkit.org/show_bug.cgi?id=194345
Attachments:
Description Flags
Test results from --ipad-simulator test run
none
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2019-01-24 07:08:44 PST
We need to garden test results for iPad.
Attachments
Test results from --ipad-simulator test run (52.43 MB, application/zip)
2019-01-24 07:10 PST, Jonathan Bedard 		no flags
Details
Patch (52.75 KB, patch)
2019-02-01 11:43 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (77.08 KB, patch)
2019-02-04 13:34 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (4.67 KB, patch)
2019-02-06 09:02 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-01-24 07:10:34 PST
Created attachment 360010 [details] Test results from --ipad-simulator test run
Radar WebKit Bug Importer
Comment 2 2019-01-24 07:22:42 PST
<rdar://problem/47515175>
Jonathan Bedard
Comment 3 2019-01-25 11:01:18 PST
Comment on attachment 360010 [details] Test results from --ipad-simulator test run Seems like many of these test failure are due to the machine running the tests going to sleep, so the results aren't very helpful.
Jonathan Bedard
Comment 4 2019-02-01 11:43:19 PST
Created attachment 360879 [details] Patch
Jonathan Bedard
Comment 5 2019-02-01 11:45:46 PST
(In reply to Jonathan Bedard from comment #4) > Created attachment 360879 [details] > Patch Starting to iterate on this. This patch would make the iPad testers "Green," but I would like to audit the tests marked as failed or skipped before landing, since many of those tests may be compatible with iPad given minor changes.
Jonathan Bedard
Comment 6 2019-02-04 13:34:17 PST
Created attachment 361090 [details] Patch
Jonathan Bedard
Comment 7 2019-02-04 21:55:37 PST
(In reply to Jonathan Bedard from comment #6) > Created attachment 361090 [details] > Patch This patch re-baselines tests for iPad. It does not skip tests which are failing, or make any changes to UIScriptController.
WebKit Commit Bot
Comment 8 2019-02-04 22:19:56 PST
Comment on attachment 361090 [details] Patch Clearing flags on attachment: 361090 Committed r240964: <https://trac.webkit.org/changeset/240964>
WebKit Commit Bot
Comment 9 2019-02-04 22:19:57 PST
All reviewed patches have been landed. Closing bug.
Jonathan Bedard
Comment 10 2019-02-06 09:02:14 PST
Reopening to attach new patch.
Jonathan Bedard
Comment 11 2019-02-06 09:02:15 PST
Created attachment 361298 [details] Patch
WebKit Commit Bot
Comment 12 2019-02-06 10:24:37 PST
Comment on attachment 361298 [details] Patch Clearing flags on attachment: 361298 Committed r241028: <https://trac.webkit.org/changeset/241028>
WebKit Commit Bot
Comment 13 2019-02-06 10:24:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.