Bug 190757

Summary: Make synchronous IPC introduced in r237267 asynchronous
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2018-10-19 11:24:17 PDT
Make synchronous IPC introduced in r237267 asynchronous
Attachments
Patch (15.65 KB, patch)
2018-10-19 11:26 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (14.64 KB, patch)
2018-11-27 16:53 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-10-19 11:26:45 PDT
Created attachment 352807 [details] Patch
Chris Dumez
Comment 2 2018-10-22 10:15:34 PDT
Comment on attachment 352807 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352807&action=review Looks good but I have one concern about the autorelease. > Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:584 > + completionHandler(array); Any reason you dropped the autorelease?
Alex Christensen
Comment 3 2018-10-23 20:42:58 PDT
Comment on attachment 352807 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352807&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:584 >> + completionHandler(array); > > Any reason you dropped the autorelease? That does indeed introduce a memory leak. Will fix.
Alex Christensen
Comment 4 2018-11-27 16:53:19 PST
Created attachment 355822 [details] Patch
WebKit Commit Bot
Comment 5 2018-11-27 17:43:43 PST
The commit-queue encountered the following flaky tests while processing attachment 355822 [details]: workers/bomb.html bug 171985 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2018-11-27 17:44:37 PST
Comment on attachment 355822 [details] Patch Clearing flags on attachment: 355822 Committed r238593: <https://trac.webkit.org/changeset/238593>
WebKit Commit Bot
Comment 7 2018-11-27 17:44:39 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-11-27 17:46:03 PST
<rdar://problem/46295880>
Note You need to log in before you can comment on or make changes to this bug.