Bug 187955

Summary: [WTF] String::formatWithArguments() is unused
Product: WebKit Reporter: Tomas Popela <tpopela>
Component: Web Template FrameworkAssignee: Tomas Popela <tpopela>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, dbates, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 30342    
Attachments:
Description Flags
Patch
none
Patch darin: review+

Tomas Popela
Reported 2018-07-24 04:44:20 PDT
String::formatWithArguments() in Source/WTF/wtf/text/WTFString.h is unused, let's remove it.
Attachments
Patch (2.02 KB, patch)
2018-07-24 04:45 PDT, Tomas Popela 		no flags
DetailsFormatted DiffDiff
Patch (4.63 KB, patch)
2018-07-24 06:36 PDT, Tomas Popela 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tomas Popela
Comment 1 2018-07-24 04:45:45 PDT
Created attachment 345659 [details] Patch
Tomas Popela
Comment 2 2018-07-24 06:36:27 PDT
Created attachment 345668 [details] Patch
Darin Adler
Comment 3 2018-07-28 23:30:35 PDT
After doing this we should rename String::format to String::deprecatedFormat and start phasing it out. Clients can and should use string concatenation, clearly invokable as makeString or possibly just with the + operator, instead. More efficient, likely safer. A few clients might be using advanced features of printf, but even those could probably be added to the concatenation.
Tomas Popela
Comment 4 2018-07-31 01:11:15 PDT
(In reply to Darin Adler from comment #3) > After doing this we should rename String::format to String::deprecatedFormat > and start phasing it out. Clients can and should use string concatenation, > clearly invokable as makeString or possibly just with the + operator, > instead. More efficient, likely safer. A few clients might be using advanced > features of printf, but even those could probably be added to the > concatenation. Thank you for the review Darin! I open bug 188191 for that.
Tomas Popela
Comment 5 2018-07-31 02:21:04 PDT
Committed r234411: <https://trac.webkit.org/changeset/234411>
Radar WebKit Bug Importer
Comment 6 2018-07-31 02:22:26 PDT
<rdar://problem/42765297>
Note You need to log in before you can comment on or make changes to this bug.