Bug 182007

Summary: REGRESSION (r227340): Layout Test fast/workers/worker-cloneport.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, ggaren, jlewis3, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=181922
https://bugs.webkit.org/show_bug.cgi?id=205357
Attachments:
Description Flags
Patch
none
Patch none

Ryan Haddad
Reported 2018-01-23 13:03:57 PST
The following layout test is flaky on macOS Release WK2 fast/workers/worker-cloneport.html Probable cause: Unknown. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fworkers%2Fworker-cloneport.html --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/fast/workers/worker-cloneport-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/fast/workers/worker-cloneport-actual.txt @@ -1,6 +1,7 @@ Test MessagePort messaging/entangle/detangle across threads. Should print "SUCCESS" when done. PASS: Received request for 50000 messages +FAILURE: Received: 0 events - expected: 50000 SUCCESS - received 50000 messages. DONE
Attachments
Patch (2.21 KB, patch)
2018-01-31 14:48 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.23 KB, patch)
2018-01-31 14:56 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2018-01-29 15:49:51 PST
This regressed with https://trac.webkit.org/changeset/227340/webkit I can reproduce the failure with a build of r227340 using the following: run-webkit-tests fast/workers/worker-cloneport.html -fg --iter 25 --no-retry-failure I cannot reproduce with r227339.
Radar WebKit Bug Importer
Comment 2 2018-01-29 15:51:04 PST
<rdar://problem/37005504>
Brady Eidson
Comment 3 2018-01-29 19:27:37 PST
(In reply to Ryan Haddad from comment #0) > The following layout test is flaky on macOS Release WK2 > > fast/workers/worker-cloneport.html > > Probable cause: > > Unknown. How sure are we there's no crashes?
Chris Dumez
Comment 4 2018-01-29 19:29:02 PST
(In reply to Brady Eidson from comment #3) > (In reply to Ryan Haddad from comment #0) > > The following layout test is flaky on macOS Release WK2 > > > > fast/workers/worker-cloneport.html > > > > Probable cause: > > > > Unknown. > > How sure are we there's no crashes? https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r227764%20(2595)/results.html shows no crash
Matt Lewis
Comment 5 2018-01-30 16:46:30 PST
marked as flaky on macOS release: https://trac.webkit.org/changeset/227865/webkit
Chris Dumez
Comment 6 2018-01-31 14:37:46 PST
I can easily reproduce the issue with the command provided by Ryan.
Chris Dumez
Comment 7 2018-01-31 14:45:26 PST
PASS: Received request for 50000 messages +FAILURE: Received: 0 events - expected: 50000 // Evidence a timeout timer has fired too early SUCCESS - received 50000 messages. // Evidence the test is succeeding. DONE The code looks like: // Queue up a task to execute once the messages have been processed. The timeout value is set fairly large to account for Chromium's different message delivery architecture. // This only fires in the case of a test failure, so it does not slow down test running. var timer = setTimeout(function() { log("FAILURE: Received: " + itemNum + " events - expected: " + numMessages); }, 1000); So if we've not received all the messages within one second, that line will be printed out. This is clearly an issue with the test.
Chris Dumez
Comment 8 2018-01-31 14:48:59 PST
Created attachment 332803 [details] Patch
Ryosuke Niwa
Comment 9 2018-01-31 14:52:52 PST
Comment on attachment 332803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332803&action=review > LayoutTests/fast/workers/worker-cloneport.html:60 > - }, 1000); > + }, 20000); 20s? That's more than DRTs timeout. How about 8s?
Chris Dumez
Comment 10 2018-01-31 14:56:27 PST
Created attachment 332805 [details] Patch
Chris Dumez
Comment 11 2018-01-31 14:57:01 PST
(In reply to Ryosuke Niwa from comment #9) > Comment on attachment 332803 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332803&action=review > > > LayoutTests/fast/workers/worker-cloneport.html:60 > > - }, 1000); > > + }, 20000); > > 20s? That's more than DRTs timeout. How about 8s? Deal.
WebKit Commit Bot
Comment 12 2018-01-31 15:22:36 PST
Comment on attachment 332805 [details] Patch Clearing flags on attachment: 332805 Committed r227935: <https://trac.webkit.org/changeset/227935>
WebKit Commit Bot
Comment 13 2018-01-31 15:22:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.