Bug 181966

Summary: Layout Test media/W3C/audio/events/event_progress.html is flaky
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: New BugsAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, peng.liu6, philipj, ryanhaddad, sergio, sroberts, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=196637
https://bugs.webkit.org/show_bug.cgi?id=186666
https://bugs.webkit.org/show_bug.cgi?id=191684
https://bugs.webkit.org/show_bug.cgi?id=184614
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Matt Lewis
Reported 2018-01-22 17:26:05 PST
The following layout tests are flaky on macOS Debug media/W3C/audio/events/event_progress.html media/W3C/video/events/event_order_loadstart_progress.html Probable cause: This has been flaky for an extended period of time and the failures extend beyond the flakiness dashboard Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2FW3C%2Faudio%2Fevents%2Fevent_progress.html build: https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r227351%20(1725)/results.html https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/builds/1725 diff: --- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/W3C/audio/events/event_progress-expected.txt +++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/W3C/audio/events/event_progress-actual.txt @@ -6,6 +6,9 @@ PASS true is true TEST COMPLETE +PASS true is true + +TEST COMPLETE spec reference It looks like the tests are intermittently duplicating the pass message.
Attachments
Patch (13.33 KB, patch)
2019-10-10 14:45 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Patch (11.41 KB, patch)
2019-10-10 16:32 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Patch (6.00 KB, patch)
2019-10-11 13:25 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Lewis
Comment 1 2018-01-22 17:27:29 PST
Flakiness dashboard for media/W3C/video/events/event_order_loadstart_progress.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2FW3C%2Fvideo%2Fevents%2Fevent_order_loadstart_progress.html
Matt Lewis
Comment 2 2018-01-23 15:22:19 PST
Marked as flaky in https://trac.webkit.org/changeset/227454/webkit
Radar WebKit Bug Importer
Comment 3 2019-06-05 11:31:28 PDT
<rdar://problem/51449034>
Peng Liu
Comment 4 2019-10-10 14:20:15 PDT
*** Bug 175678 has been marked as a duplicate of this bug. ***
Peng Liu
Comment 5 2019-10-10 14:21:09 PDT
*** Bug 177663 has been marked as a duplicate of this bug. ***
Peng Liu
Comment 6 2019-10-10 14:45:12 PDT
Created attachment 380689 [details] Patch
Peng Liu
Comment 7 2019-10-10 16:32:49 PDT
Created attachment 380697 [details] Patch
WebKit Commit Bot
Comment 8 2019-10-11 08:21:01 PDT
Comment on attachment 380697 [details] Patch Clearing flags on attachment: 380697 Committed r251009: <https://trac.webkit.org/changeset/251009>
WebKit Commit Bot
Comment 9 2019-10-11 08:21:03 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 10 2019-10-11 08:49:05 PDT
Comment on attachment 380697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380697&action=review > LayoutTests/ChangeLog:16 > + * http/tests/resources/js-test-pre.js: > + (isSuccessfullyParsed): I don't see any changes to this file in this patch. > LayoutTests/ChangeLog:25 > + * platform/ios/TestExpectations: > + * platform/mac/TestExpectations: I related some more bugs about tests unmarked here. > LayoutTests/media/W3C/audio/events/event_order_loadstart_progress.html:20 > +var firstProgressEvent = true; I think that you can just use {once: true} here and elsewhere in this change. > LayoutTests/media/W3C/audio/events/event_order_loadstart_progress.html:22 > + if (!firstProgressEvent) return; WebKit coding style would be to have "return;" on its own line. But perhaps you are matching coding style of this test suite? I don't see existing examples in this diff.
Peng Liu
Comment 11 2019-10-11 09:27:11 PDT
Comment on attachment 380697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380697&action=review >> LayoutTests/ChangeLog:16 >> + (isSuccessfullyParsed): > > I don't see any changes to this file in this patch. Ah, forgot to review the list of changes after revising the patch. >> LayoutTests/media/W3C/audio/events/event_order_loadstart_progress.html:20 >> +var firstProgressEvent = true; > > I think that you can just use {once: true} here and elsewhere in this change. Right! >> LayoutTests/media/W3C/audio/events/event_order_loadstart_progress.html:22 >> + if (!firstProgressEvent) return; > > WebKit coding style would be to have "return;" on its own line. But perhaps you are matching coding style of this test suite? I don't see existing examples in this diff. Right, it needs to be fixed. If we use the "once" option on addEventListner, then this line needs to be removed.
Peng Liu
Comment 12 2019-10-11 13:25:46 PDT
Reopening to attach new patch.
Peng Liu
Comment 13 2019-10-11 13:25:47 PDT
Created attachment 380779 [details] Patch
WebKit Commit Bot
Comment 14 2019-10-11 16:47:51 PDT
Comment on attachment 380779 [details] Patch Clearing flags on attachment: 380779 Committed r251030: <https://trac.webkit.org/changeset/251030>
WebKit Commit Bot
Comment 15 2019-10-11 16:47:53 PDT
All reviewed patches have been landed. Closing bug.
Peng Liu
Comment 16 2019-10-11 21:29:27 PDT
*** Bug 196637 has been marked as a duplicate of this bug. ***
Peng Liu
Comment 17 2019-10-11 23:32:35 PDT
*** Bug 184614 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.