Bug 177769

Summary: Implement quality-of-service tiers in WebCoreDecompressionSession
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Jer Noble
Reported 2017-10-02 13:17:42 PDT
Implement quality-of-service tiers in WebCoreDecompressionSession
Attachments
Patch (12.11 KB, patch)
2017-10-02 13:20 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.85 KB, patch)
2017-10-02 13:37 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.64 KB, patch)
2017-10-02 15:12 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.64 KB, patch)
2017-10-02 15:33 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.05 KB, patch)
2017-10-03 09:12 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-10-02 13:20:31 PDT
Created attachment 322418 [details] Patch
Radar WebKit Bug Importer
Comment 2 2017-10-02 13:20:41 PDT
<rdar://problem/34774531>
Radar WebKit Bug Importer
Comment 3 2017-10-02 13:20:45 PDT
<rdar://problem/34774533>
Dean Jackson
Comment 4 2017-10-02 13:29:56 PDT
Comment on attachment 322418 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322418&action=review > Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:269 > + LOG(Media, "WebCoreDecompressionSession::decodeSample(%p) - decoding took %g%% of duration (%gs vs. %gs)", this, 100. * deltaRatio, delta, duration); Won't this produce a LOT of log spew? Maybe do it every N frames as an average?
Jer Noble
Comment 5 2017-10-02 13:32:49 PDT
(In reply to Dean Jackson from comment #4) > Comment on attachment 322418 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322418&action=review > > > Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:269 > > + LOG(Media, "WebCoreDecompressionSession::decodeSample(%p) - decoding took %g%% of duration (%gs vs. %gs)", this, 100. * deltaRatio, delta, duration); > > Won't this produce a LOT of log spew? Maybe do it every N frames as an > average? Sure we can drop it. The "every N frames as an average" is the logging in updateQosWithDecodeTimeStatistics().
Jer Noble
Comment 6 2017-10-02 13:37:03 PDT
Created attachment 322422 [details] Patch for landing
Jer Noble
Comment 7 2017-10-02 15:12:02 PDT
Created attachment 322452 [details] Patch for landing
Jer Noble
Comment 8 2017-10-02 15:33:41 PDT
Created attachment 322460 [details] Patch for landing
Jer Noble
Comment 9 2017-10-03 09:12:50 PDT
Created attachment 322530 [details] Patch for landing
WebKit Commit Bot
Comment 10 2017-10-03 12:56:38 PDT
Comment on attachment 322530 [details] Patch for landing Clearing flags on attachment: 322530 Committed r222803: <http://trac.webkit.org/changeset/222803>
WebKit Commit Bot
Comment 11 2017-10-03 12:56:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.