Bug 177123

Summary: Cannot put typedefs of templated structs inside structs
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, msaboff, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
the patch msaboff: review+

Myles C. Maxfield
Reported 2017-09-18 21:26:35 PDT
>>> prepare("/internal/test", 0, "struct Foo { int2 x; }") Exception: Error: Cannot determine if an uninstantiated type is primitive: vec2<int32>
Attachments
the patch (6.82 KB, patch)
2017-09-18 22:07 PDT, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-09-18 22:07:25 PDT
Created attachment 321181 [details] the patch
Michael Saboff
Comment 2 2017-09-19 09:34:46 PDT
Comment on attachment 321181 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=321181&action=review r=me > Tools/ChangeLog:39 > + type. This chews threw the wrapper and then instantiates the wrapped type, as we want it to. Change "threw" to "through"
Filip Pizlo
Comment 3 2017-09-19 09:39:53 PDT
Landed in https://trac.webkit.org/changeset/222210/webkit
Radar WebKit Bug Importer
Comment 4 2017-09-27 12:52:45 PDT
<rdar://problem/34694197>
Myles C. Maxfield
Comment 5 2018-10-13 19:36:33 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/181
Note You need to log in before you can comment on or make changes to this bug.