Bug 177064

Summary: Start working on WSL documentation
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
the patch
none
the patch mmaxfield: review+

Filip Pizlo
Reported 2017-09-17 19:29:35 PDT
Patch forthcoming.
Attachments
the patch (9.86 KB, patch)
2017-09-17 19:30 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (15.65 KB, patch)
2017-09-17 21:05 PDT, Filip Pizlo 		mmaxfield: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-09-17 19:30:24 PDT
Created attachment 321066 [details] the patch
Filip Pizlo
Comment 2 2017-09-17 21:05:27 PDT
Created attachment 321073 [details] the patch
Filip Pizlo
Comment 3 2017-09-17 22:06:34 PDT
Landed in https://trac.webkit.org/changeset/222140/webkit
Myles C. Maxfield
Comment 4 2017-09-17 22:19:01 PDT
Comment on attachment 321073 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=321073&action=review > Tools/WebGPUShadingLanguageRI/WSL.md:284 > + int y; I think you meant double here.
Myles C. Maxfield
Comment 5 2017-09-17 22:24:02 PDT
Comment on attachment 321073 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=321073&action=review > Tools/WebGPUShadingLanguageRI/WSL.md:311 > +- Read-modify-write operators like `+=` are desugared to a load of the load value, the underlying operator (like `+`), and a store of the new value. It's not possible to override `+=`, `-=`, etc. I think right now it is. We should remove this functionality if this isn't desired.
Myles C. Maxfield
Comment 6 2017-09-18 09:55:43 PDT
"Mylex Maxfield" 😖
Filip Pizlo
Comment 7 2017-09-18 10:42:09 PDT
(In reply to Myles C. Maxfield from comment #6) > "Mylex Maxfield" 😖 oops!
Radar WebKit Bug Importer
Comment 8 2017-09-27 12:26:25 PDT
<rdar://problem/34693280>
Myles C. Maxfield
Comment 9 2018-10-13 16:30:27 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/124
Note You need to log in before you can comment on or make changes to this bug.