Bug 177062

Summary: WSL needs to understand && and ||
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, keith_miller, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
Patch none

Myles C. Maxfield
Reported 2017-09-17 18:29:02 PDT
WSL needs to understand && and ||
Attachments
Patch (15.38 KB, patch)
2017-09-17 18:30 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2017-09-17 18:30:10 PDT
Created attachment 321060 [details] Patch
Filip Pizlo
Comment 2 2017-09-17 20:00:28 PDT
Comment on attachment 321060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321060&action=review > Tools/WebGPUShadingLanguageRI/Evaluator.js:175 > + case "&&": Nice. I like that you’re just using the operator itself.
WebKit Commit Bot
Comment 3 2017-09-17 20:39:23 PDT
Comment on attachment 321060 [details] Patch Clearing flags on attachment: 321060 Committed r222139: <http://trac.webkit.org/changeset/222139>
WebKit Commit Bot
Comment 4 2017-09-17 20:39:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:29:29 PDT
<rdar://problem/34693373>
Myles C. Maxfield
Comment 6 2018-10-13 16:32:34 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/126
Note You need to log in before you can comment on or make changes to this bug.