Bug 176290

Summary: WSL should support structs
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
the patch mmaxfield: review+

Filip Pizlo
Reported 2017-09-02 20:44:19 PDT
Patch forthcoming.
Attachments
the patch (41.64 KB, patch)
2017-09-02 20:48 PDT, Filip Pizlo 		mmaxfield: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-09-02 20:48:24 PDT
Created attachment 319756 [details] the patch
Filip Pizlo
Comment 2 2017-09-02 21:18:05 PDT
Comment on attachment 319756 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=319756&action=review > Tools/WebGPUShadingLanguageRI/FuncInstantiator.js:99 > - let resultingFunc = func.visit(new Instantiate()); > + > + let resultingFunc = func.visit(new Instantiate(substitution)); I'll revert. > Tools/WebGPUShadingLanguageRI/InstantiateImmediates.js:44 > + > + visitVariableDecl(node) > + { > + let result = super.visitVariableDecl(node); > + return result; > + } I will remove.
Filip Pizlo
Comment 3 2017-09-03 10:48:12 PDT
Landed in https://trac.webkit.org/changeset/221550/webkit
Radar WebKit Bug Importer
Comment 4 2017-09-27 12:55:25 PDT
<rdar://problem/34694277>
Myles C. Maxfield
Comment 5 2018-10-13 17:05:36 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/157
Note You need to log in before you can comment on or make changes to this bug.