Bug 174432

Summary: Async image decoding for large images should be disabled by default
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: ImagesAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, thorton, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Said Abou-Hallawa
Reported 2017-07-12 11:51:06 PDT
Currently the PaintBehaviorSnapshotting prevents drawing the image asynchronously. The only use of this flag is to disable async image decoding for large images. We need to flip the name and use of this flag such that async image decoding for large images will be disabled by default and it will be enabled only when this is explicitly specified.
Attachments
Patch (26.49 KB, patch)
2017-07-12 12:16 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (25.57 KB, patch)
2017-07-12 12:41 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (25.09 KB, patch)
2017-07-12 13:10 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (25.06 KB, patch)
2017-07-12 16:40 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2017-07-12 12:16:24 PDT
Created attachment 315268 [details] Patch
Said Abou-Hallawa
Comment 2 2017-07-12 12:41:55 PDT
Created attachment 315274 [details] Patch
alan
Comment 3 2017-07-12 12:45:34 PDT
Comment on attachment 315268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315268&action=review > Source/WebCore/rendering/RenderElement.h:223 > + DecodingMode decodingModeForImageDraw(const PaintInfo&) const; This method does not need to be public and can live on RenderBoxModelObject.
Said Abou-Hallawa
Comment 4 2017-07-12 12:48:13 PDT
Comment on attachment 315268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315268&action=review >> Source/WebCore/rendering/RenderElement.h:223 >> + DecodingMode decodingModeForImageDraw(const PaintInfo&) const; > > This method does not need to be public and can live on RenderBoxModelObject. But it is used by RenderImage as well.
alan
Comment 5 2017-07-12 12:56:04 PDT
(In reply to Said Abou-Hallawa from comment #4) > Comment on attachment 315268 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=315268&action=review > > >> Source/WebCore/rendering/RenderElement.h:223 > >> + DecodingMode decodingModeForImageDraw(const PaintInfo&) const; > > > > This method does not need to be public and can live on RenderBoxModelObject. > > But it is used by RenderImage as well. RenderImage is the renderer for <img> element which is a replaced element -> requires visual box properties -> RenderBoxModelObject
Said Abou-Hallawa
Comment 6 2017-07-12 13:10:37 PDT
Created attachment 315276 [details] Patch
Simon Fraser (smfr)
Comment 7 2017-07-12 13:57:01 PDT
Comment on attachment 315276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315276&action=review > Source/WebCore/ChangeLog:13 > + -- Propagate PaintBehaviorAllowAsyncImageDecoding a from parent view to ' a from '
Said Abou-Hallawa
Comment 8 2017-07-12 16:40:26 PDT
Created attachment 315303 [details] Patch
WebKit Commit Bot
Comment 9 2017-07-12 19:20:23 PDT
Comment on attachment 315303 [details] Patch Clearing flags on attachment: 315303 Committed r219438: <http://trac.webkit.org/changeset/219438>
WebKit Commit Bot
Comment 10 2017-07-12 19:20:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.