Bug 173695

Summary: [GCrypt] Implement CryptoKeyRSA SPKI exports
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, jiewen_tan, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 173646    
Bug Blocks: 133122, 173697    
Attachments:
Description Flags
WIP patch
none
WIP patch
none
Patch
none
Patch jiewen_tan: review+

Zan Dobersek
Reported 2017-06-21 23:18:47 PDT
SSIA.
Attachments
WIP patch (13.37 KB, patch)
2017-06-21 23:41 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
WIP patch (9.48 KB, patch)
2017-06-26 04:58 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (11.34 KB, patch)
2017-06-28 09:25 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (11.44 KB, patch)
2017-07-03 01:01 PDT, Zan Dobersek 		jiewen_tan: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-06-21 23:41:20 PDT
Created attachment 313588 [details] WIP patch
Build Bot
Comment 2 2017-06-22 00:16:33 PDT
Attachment 313588 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 3 2017-06-26 04:58:31 PDT
Created attachment 313827 [details] WIP patch
Build Bot
Comment 4 2017-06-26 05:01:50 PDT
Attachment 313827 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 5 2017-06-28 09:25:57 PDT
Created attachment 314028 [details] Patch
Zan Dobersek
Comment 6 2017-06-28 09:26:10 PDT
(In reply to Zan Dobersek from comment #5) > Created attachment 314028 [details] > Patch This is ready for review, but the patch still relies on libtasn1 helpers that are being added in bug #173646.
Zan Dobersek
Comment 7 2017-07-03 01:01:44 PDT
Created attachment 314462 [details] Patch Now buildable.
Jiewen Tan
Comment 8 2017-07-12 11:39:10 PDT
Comment on attachment 314462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314462&action=review Looks good to me. r=me. > Source/WebCore/ChangeLog:29 > + A helper mpiSignedData() function is added, providing overloads for gcry_mpi_t Interesting. > Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:304 > + if (!PAL::TASN1::writeElement(spki, "algorithm.algorithm", "1.2.840.113549.1.1.1", 1)) Remember we should replace "1.2.840.113549.1.1.1" with a constant. > Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:308 > + if (!PAL::TASN1::writeElement(spki, "algorithm.parameters", "\x05\x00", 2)) Another constant here?
Zan Dobersek
Comment 9 2017-07-13 03:09:03 PDT
Committed r219449: <http://trac.webkit.org/changeset/219449>
Note You need to log in before you can comment on or make changes to this bug.