Bug 173693

Summary: Add some thread safety guards to GenericCallback
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ggaren, mitz, rniwa, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brady Eidson
Reported 2017-06-21 22:35:51 PDT
Add some thread safety guards to GenericCallback A callback should be created, performed, invalidated, and/or destroyed all on the same thread. Let's write code to notify us if that doesn't happen.
Attachments
Patch (2.25 KB, patch)
2017-06-21 22:38 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-06-21 22:38:46 PDT
Created attachment 313585 [details] Patch
Brady Eidson
Comment 2 2017-06-21 22:39:22 PDT
(I haven't even compiled yet, justing throwing this at EWS for now)
WebKit Commit Bot
Comment 3 2017-06-22 10:34:39 PDT
Comment on attachment 313585 [details] Patch Clearing flags on attachment: 313585 Committed r218705: <http://trac.webkit.org/changeset/218705>
WebKit Commit Bot
Comment 4 2017-06-22 10:34:40 PDT
All reviewed patches have been landed. Closing bug.
mitz
Comment 5 2017-06-22 10:42:10 PDT
Comment on attachment 313585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313585&action=review > Source/WebKit2/UIProcess/GenericCallback.h:153 > +#ifndef NDEBUG This should be #if !ASSERT_DISABLED instead.
Note You need to log in before you can comment on or make changes to this bug.