Bug 173375
| Summary: | REGRESSION (r218228): Layout Test editing/execCommand/strikethrough-uses-strike-tag.html is failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Lewis <jlewis3> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | ap, ryanhaddad, zalan |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=173330 https://bugs.webkit.org/show_bug.cgi?id=173380 |
||
Matt Lewis
editing/execCommand/strikethrough-uses-strike-tag.html started failing after revision r218228 https://trac.webkit.org/changeset/218228/webkit
I spoke with Zalan about the revision and failure. Test just needed re-baselining.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Matt Lewis
Re-baselined test:
https://trac.webkit.org/changeset/218273/webkit
Matt Lewis
Fixed typo:
https://trac.webkit.org/changeset/218279/webkit
Matt Lewis
After the Re-baseline, the test began to pass on release, but the Debug builds began to fail.
Debug diff
--- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/editing/execCommand/strikethrough-uses-strike-tag-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/editing/execCommand/strikethrough-uses-strike-tag-actual.txt
@@ -1,4 +1,3 @@
-Blocked access to external URL https://www.webkit.org/
Ensuring we continue to use strike tags for legacy strikethrough execCommands, not s tags. See https://bugs.webkit.org/show_bug.cgi?id=53475
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Alexey Proskuryakov
> -Blocked access to external URL https://www.webkit.org/
This output is coming from the preceding test editing/execCommand/show-modal-dialog-during-execCommand.html, which is now unskipped, but only in release.
Zalan, could you please take a look? Clearly, we shouldn't leak output from the preceding test.
alan
(In reply to Alexey Proskuryakov from comment #4)
> > -Blocked access to external URL https://www.webkit.org/
>
> This output is coming from the preceding test
> editing/execCommand/show-modal-dialog-during-execCommand.html, which is now
> unskipped, but only in release.
>
> Zalan, could you please take a look? Clearly, we shouldn't leak output from
> the preceding test.
Oh, I was under the impression that the unskipped test(show-modal-dialog-during-execCommand.html) needed rebaselining. I agree, it's not okay to leak output from any test. I will surely look at it though I am not the best person to deal with such failures.
Matt Lewis
Spoke with zalan, reverted re-baseline and re-implemented skip.
https://trac.webkit.org/changeset/218346/webkit