Bug 172870

Summary: [GCrypt] Gather SUBTLE_CRYPTO utility functions in a single header
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, jiewen_tan, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 133122    
Attachments:
Description Flags
Patch jiewen_tan: review+

Zan Dobersek
Reported 2017-06-02 13:03:51 PDT
[GCrypt] Gather Web Crypto utility functions in a single header
Attachments
Patch (21.52 KB, patch)
2017-06-02 13:09 PDT, Zan Dobersek 		jiewen_tan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-06-02 13:09:59 PDT
Created attachment 311849 [details] Patch
Build Bot
Comment 2 2017-06-02 13:12:11 PDT
Attachment 311849 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/gcrypt/GCryptUtilities.h:68: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jiewen Tan
Comment 3 2017-06-02 16:40:44 PDT
Comment on attachment 311849 [details] Patch Looks good to me. Michael, please double checks if there are any missing ones.
Michael Catanzaro
Comment 4 2017-06-02 18:05:03 PDT
Comment on attachment 311849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311849&action=review Looks good to me as well... I just wonder why it wasn't written this way from the start! > Source/WebCore/crypto/gcrypt/GCryptUtilities.h:68 > + return std::nullopt;; One too many semicolons!
Jiewen Tan
Comment 5 2017-06-02 18:50:50 PDT
Comment on attachment 311849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311849&action=review >> Source/WebCore/crypto/gcrypt/GCryptUtilities.h:68 >> + return std::nullopt;; > > One too many semicolons! Oops...
Zan Dobersek
Comment 6 2017-06-03 03:29:35 PDT
Committed r217754: <http://trac.webkit.org/changeset/217754>
Note You need to log in before you can comment on or make changes to this bug.