Bug 17217
| Summary: | add COMPILE_ASSERT(sizeof(Foo) == 32) for classes we're trying to keep small | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | aroben, cwhong893, ddkilzer, hyatt, sam, simon.fraser, ysuzuki, zalan |
| Priority: | P2 | Keywords: | EasyFix |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
| Bug Depends on: | 55088 | ||
| Bug Blocks: | |||
Eric Seidel (no email)
add COMPILE_ASSERT(sizeof(Foo) == 32) for classes we're trying to keep small
Now that we have these magical COMPILE_ASSERTs we should use them to make sure we don't accidentally inflate core classes with changes.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
Simon or Alan: Is there anything actionable here? Eric didn't list specific classes when he filed this, so I'm not sure which ones he was thinking of.
Simon Fraser (smfr)
Nah.
Yusuke Suzuki
I don't think this bug itself is actionable.
But, note that we are already doing this thing for some of super important classes (in particular in JSC).
e.g. https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp#L47