Bug 169987

Summary: NeverDestroyed<MediaQueryEvaluator> must explicitly construct with a String
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sam
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 169245    
Attachments:
Description Flags
Patch achristensen: review+

Dean Jackson
Reported 2017-03-22 18:52:24 PDT
CSSDefaultStyleSheets creates a static MediaQueryEvaluator, but thanks to the template magic of NeverDestroyed, it was converting the char* argument into a bool, and calling the wrong constructor.
Attachments
Patch (2.20 KB, patch)
2017-03-22 18:57 PDT, Dean Jackson 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2017-03-22 18:53:04 PDT
<rdar://problem/31211087>
Dean Jackson
Comment 2 2017-03-22 18:57:04 PDT
Created attachment 305152 [details] Patch
Dean Jackson
Comment 3 2017-03-23 11:19:12 PDT
Committed r214305: <http://trac.webkit.org/changeset/214305>
Note You need to log in before you can comment on or make changes to this bug.