Bug 165321
| Summary: | [JSC] Stop nulling out the CodeBlock spot inside the call frame inside WebAssembly | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> |
| Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | benjamin, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, oliver, ticaiolima, webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Saam Barati
A lot of places interpreter non-zero CodeBlock bits to mean a valid CodeBlock. When I do wasm unwinding, I'll need to monitor the code that touches this to make sure it refers to the callee before the CodeBlock to test for a wasm frame. Until then, we'll store zero into that slot just to be safe.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/103618930>
Yusuke Suzuki
Pull request: https://github.com/WebKit/WebKit/pull/7991
EWS
Committed 258233@main (5f73a3c6800b): <https://commits.webkit.org/258233@main>
Reviewed commits have been landed. Closing PR #7991 and removing active labels.