Bug 164938

Summary:

Remove the deprecated WebKitSubtleCrypto interface

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebCore Misc.

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bfulgham, buildbot, cdumez, jiewen_tan, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=160880

Bug Depends on:

164943, 164939, 169806

Bug Blocks:

173325

Attachments:

Description	Flags
Patch	none
Patch	cdumez: review+

Jiewen Tan

Reported 2016-11-18 11:31:21 PST

This is an umbrella bug for deprecating WebKitSubtleCrypto.

Attachments
Patch (499.67 KB, patch) 2017-08-18 14:24 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (504.18 KB, patch) 2017-08-18 14:58 PDT, Sam Weinig	cdumez: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-01-05 18:16:03 PST

<rdar://problem/29894563>

Sam Weinig

Comment 2 2017-08-16 16:55:01 PDT

Jiewen, are you working on this? If not, I'll take it.

Jiewen Tan

Comment 3 2017-08-16 17:04:37 PDT

(In reply to Sam Weinig from comment #2) > Jiewen, are you working on this? If not, I'll take it. No, I am not. Feel free to take it.

Sam Weinig

Comment 4 2017-08-17 10:38:02 PDT

(In reply to Jiewen Tan from comment #3) > (In reply to Sam Weinig from comment #2) > > Jiewen, are you working on this? If not, I'll take it. > > No, I am not. Feel free to take it. Great.

Sam Weinig

Comment 5 2017-08-18 14:24:13 PDT Comment hidden (obsolete)

Created attachment 318540 [details] Patch

Build Bot

Comment 6 2017-08-18 14:28:48 PDT Comment hidden (obsolete)

Attachment 318540 [details] did not pass style-queue: ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:795: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:796: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:797: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:798: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:799: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:800: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:801: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:802: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:803: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:804: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:805: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1008: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1009: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1010: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1011: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:260: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:261: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:262: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:263: Path does not exist. [test/expectations] [5] Total errors found: 19 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 7 2017-08-18 14:58:50 PDT

Created attachment 318545 [details] Patch

Jiewen Tan

Comment 8 2017-08-18 16:15:31 PDT

Comment on attachment 318545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318545&action=review Thank you Sam. Looks good. Please address the following comments. Just wondering if you are planning of improving the structure further after the removal of WebKitSubtle? > Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.h:53 > bool keyAlgorithmMatches(const CryptoKey&) const; Maybe we should remove this as well?

Chris Dumez

Comment 9 2017-08-18 16:22:10 PDT

Comment on attachment 318545 [details] Patch rs=me

Sam Weinig

Comment 10 2017-08-18 16:23:53 PDT

(In reply to Jiewen Tan from comment #8) > Comment on attachment 318545 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318545&action=review > > Thank you Sam. Looks good. Please address the following comments. Just > wondering if you are planning of improving the structure further after the > removal of WebKitSubtle? Yeah, this was the first pass. There are a few simplifications I was going to make after this lands. > > > Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.h:53 > > bool keyAlgorithmMatches(const CryptoKey&) const; > > Maybe we should remove this as well? If its unused, yes.

Sam Weinig

Comment 11 2017-08-18 16:25:02 PDT

Committed r220941: <http://trac.webkit.org/changeset/220941>

Note You need to log in before you can comment on or make changes to this bug.