Bug 162074

Summary: Web Inspector: adopt Object.awaitEvent in LayoutTests/inspector/model
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 161634    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2016-09-16 10:51:02 PDT
.
Attachments
Patch (17.90 KB, patch)
2016-09-16 16:40 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (17.94 KB, patch)
2016-09-19 16:23 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-09-16 10:51:23 PDT
<rdar://problem/28340084>
Devin Rousso
Comment 2 2016-09-16 16:40:14 PDT
Created attachment 289135 [details] Patch
Blaze Burg
Comment 3 2016-09-19 06:59:03 PDT
Comment on attachment 289135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289135&action=review Please post a new version that reverts setTimeout changes for EWS. then I will r+ it. > LayoutTests/inspector/model/scope-chain-node.html:77 > + InspectorTest.evaluateInPage("testAllScopes()"); Please keep this as a setTimeout. Joe says it is necessary to do this whenever we rely on stack traces not including stack frames from InspectorTest code. > LayoutTests/inspector/model/scope-chain-node.html:97 > + InspectorTest.evaluateInPage("testFunctionNameScope1()"); See above. > LayoutTests/inspector/model/scope-chain-node.html:117 > + InspectorTest.evaluateInPage("testFunctionNameScope2()"); Ditto. > LayoutTests/inspector/model/scope-chain-node.html:167 > + InspectorTest.evaluateInPage("testBlockScopes()"); Ditto.
Devin Rousso
Comment 4 2016-09-19 16:23:04 PDT
Created attachment 289274 [details] Patch
Blaze Burg
Comment 5 2016-09-20 03:13:06 PDT
Comment on attachment 289274 [details] Patch r=me
WebKit Commit Bot
Comment 6 2016-09-20 10:31:04 PDT
Comment on attachment 289274 [details] Patch Clearing flags on attachment: 289274 Committed r206152: <http://trac.webkit.org/changeset/206152>
WebKit Commit Bot
Comment 7 2016-09-20 10:31:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.