Bug 162011

Summary: Custom promise-returning functions should not throw if callee has not the expected type
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews105 for mac-yosemite-wk2
none
Patch
none
Patch for landing none

youenn fablet
Reported 2016-09-15 00:44:21 PDT
Instead, a rejected promise should be returned.
Attachments
Patch (27.94 KB, patch)
2016-09-15 02:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.02 MB, application/zip)
2016-09-15 03:48 PDT, Build Bot 		no flags
Details
Patch (28.78 KB, patch)
2016-09-15 04:59 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (26.93 KB, patch)
2016-09-16 00:19 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-09-15 00:49:47 PDT
We could reuse the same trick as for non-custom methods (using callPromiseFunction). But this would put the constraint that a new promise is returned every time the method is called, which is not always the case. It might be best to just update GenerateFunctionCastedThis to return a rejected promise.
youenn fablet
Comment 2 2016-09-15 02:45:29 PDT
Created attachment 288945 [details] Patch
Build Bot
Comment 3 2016-09-15 03:48:54 PDT
Comment on attachment 288945 [details] Patch Attachment 288945 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2078487 New failing tests: http/tests/media/media-stream/disconnected-frame-already.html
Build Bot
Comment 4 2016-09-15 03:48:57 PDT
Created attachment 288949 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
youenn fablet
Comment 5 2016-09-15 04:59:53 PDT
Created attachment 288952 [details] Patch
youenn fablet
Comment 6 2016-09-16 00:19:59 PDT
Created attachment 289041 [details] Patch for landing
WebKit Commit Bot
Comment 7 2016-09-16 00:53:46 PDT
Comment on attachment 289041 [details] Patch for landing Clearing flags on attachment: 289041 Committed r206011: <http://trac.webkit.org/changeset/206011>
WebKit Commit Bot
Comment 8 2016-09-16 00:53:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.