Bug 161727

Summary: Add support for WASM calls
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: JavaScriptCoreAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159775    
Attachments:
Description Flags
Patch
none
Patch fpizlo: review+

Keith Miller
Reported 2016-09-07 18:36:18 PDT
...
Attachments
Patch (31.85 KB, patch)
2016-10-20 13:47 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (41.70 KB, patch)
2016-10-20 18:47 PDT, Keith Miller 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-10-20 13:47:28 PDT
Created attachment 292246 [details] Patch
Keith Miller
Comment 2 2016-10-20 13:49:56 PDT
Comment on attachment 292246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292246&action=review > Source/JavaScriptCore/wasm/WASMB3IRGenerator.cpp:219 > + // m_unlinkedCalls is a mapping from a function's index to a list of callsites that need to be linked. I changed this to: // m_unlikedCalls is list of each call site and the function index whose address it should be patched with.
Michael Saboff
Comment 3 2016-10-20 15:54:13 PDT
Comment on attachment 292246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292246&action=review r=me > Source/JavaScriptCore/ChangeLog:11 > + have been compiled by the time current function has started compilation we don't know what How about ... by the time *the* current function ...? > Source/JavaScriptCore/ChangeLog:12 > + address we need to call to. For each callsite in the compiling function WASM remembers what Comma after "function"? > Source/JavaScriptCore/ChangeLog:14 > + each functions callsites are linked to the appropriate entrypoint. Hoe about '... *is* linked ...'?
Keith Miller
Comment 4 2016-10-20 18:47:15 PDT
Created attachment 292307 [details] Patch
Filip Pizlo
Comment 5 2016-10-20 19:17:07 PDT
Comment on attachment 292307 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292307&action=review Looks sensible. > Source/JavaScriptCore/wasm/WASMCallingConvention.h:53 > + : m_gpRegisterArguments(gpRegisterArguments) > + , m_fpRegisterArguments(fpRegisterArguments) I think we would normally say m_gprArgs and m_fprArgs. > Source/JavaScriptCore/wasm/WASMCallingConvention.h:59 > + B3::ValueRep marshallArgumentImpl(Vector<Reg> registerArguments, B3::Type type, size_t& count, size_t& stackOffset) const regArgs
Keith Miller
Comment 6 2016-10-21 09:05:30 PDT
Committed r207671: <http://trac.webkit.org/changeset/207671>
Note You need to log in before you can comment on or make changes to this bug.