Bug 161068

Created attachment 286725 [details] Patch

Comment on attachment 286725 [details] Patch Attachment 286725 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1928565 New failing tests: imported/w3c/web-platform-tests/html/dom/interfaces.html

Created attachment 286732 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Comment on attachment 286725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286725&action=review > Source/WebCore/loader/LoadTiming.cpp:54 > + , m_cached(false) As per coding style, this needs a prefix. E.g. m_isCached or m_wasCached.

Comment on attachment 286725 [details] Patch Attachment 286725 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1928635 New failing tests: fast/animation/request-animation-frame-detach-element.html fast/animation/request-animation-frame-detach-element2.html fast/animation/request-animation-frame-remove-client.html

Created attachment 286742 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Created attachment 286757 [details] Patch

Comment on attachment 286757 [details] Patch Attachment 286757 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1929424 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/security_location_0.sub.htm imported/w3c/web-platform-tests/html/dom/interfaces.html

Created attachment 286762 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Comment on attachment 286757 [details] Patch Attachment 286757 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1929432 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/security_location_0.sub.htm

Created attachment 286765 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Comment on attachment 286757 [details] Patch Attachment 286757 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1929772 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/security_location_0.sub.htm imported/w3c/web-platform-tests/html/dom/interfaces.html

Created attachment 286771 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Created attachment 286776 [details] Patch

Comment on attachment 286776 [details] Patch Attachment 286776 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1930142 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/security_location_0.sub.htm imported/w3c/web-platform-tests/html/dom/interfaces.html

Created attachment 286785 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Comment on attachment 286776 [details] Patch Attachment 286776 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1930239 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/security_location_0.sub.htm imported/w3c/web-platform-tests/html/dom/interfaces.html

Created attachment 286790 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Comment on attachment 286776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286776&action=review > Source/WebCore/loader/LoadTiming.cpp:54 > + , m_isCached(false) These should be in the header. m_isCached { false }; > Source/WebCore/loader/ResourceLoader.h:144 > + LoadTiming& loadTiming() { return m_loadTiming; } Can this be const? > Source/WebCore/loader/SubresourceLoader.cpp:463 > + finishTime = monotonicallyIncreasingTime(); We should probably report this time in didFail, too. Or at least something interesting. Also, finishTime is a double that is a parameter coming from somewhere. It might already have the current time. // FIXME: ... UNUSED_PARAM(finishTime); double realFinishTime = ... Same in InspectorNetworkAgent::didFinishLoading > Source/WebCore/page/PerformanceResourceTiming.cpp:173 > + if (m_loadTiming.isCached()) > + return connectStart(); These seem suspicious. I think this is covering up a problem.

Created attachment 286903 [details] Patch

Created attachment 286906 [details] Patch

Comment on attachment 286906 [details] Patch Attachment 286906 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1936689 New failing tests: imported/w3c/web-platform-tests/resource-timing/test_resource_timing.html

Created attachment 286915 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Created attachment 286919 [details] Git removed some whitespace in the test expectation for one of the Resource Timing tests.

Comment on attachment 286919 [details] Git removed some whitespace in the test expectation for one of the Resource Timing tests. Attachment 286919 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1936952 New failing tests: imported/w3c/web-platform-tests/html/dom/interfaces.html

Created attachment 286924 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Comment on attachment 286919 [details] Git removed some whitespace in the test expectation for one of the Resource Timing tests. Attachment 286919 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1937048 New failing tests: imported/w3c/web-platform-tests/html/dom/interfaces.html

Created attachment 286928 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Test failures unrelated. http://trac.webkit.org/changeset/204976