Bug 160352

Summary: Refactor data passed along for a "GetRecord" request
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, cgarcia, clopez, commit-queue, mcatanzaro, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160306    
Attachments:
Description Flags
Patch
thorton: review+, commit-queue: commit-queue-
Patch for landing
none
Patch for landing none

Brady Eidson
Reported 2016-07-29 12:21:06 PDT
Refactor data passed along for a "GetRecord" request This is laying the groundwork for some of the additional APIs that have been added in V2 of the spec.
Attachments
Patch (43.52 KB, patch)
2016-07-29 12:28 PDT, Brady Eidson 		thorton: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (41.32 KB, patch)
2016-08-01 21:55 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch for landing (41.51 KB, patch)
2016-08-01 23:12 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-07-29 12:28:16 PDT
Created attachment 284888 [details] Patch
Brady Eidson
Comment 2 2016-07-29 20:02:04 PDT
I don't know why the linux's aren't picking up the new header in WK2 - That directory *is* included in the WebCore includes directory list, and I can't currently recall a different step necessary to get a header to copy over. Any Linux folks know what's up? Or Alex?
Michael Catanzaro
Comment 3 2016-08-01 10:35:18 PDT
I don't know what's wrong, CCing more Linux folks. We don't want to block your work, so if we don't figure it out soon, go ahead and commit and we'll fix it up when we get a chance. Thanks as always for asking first.
Brady Eidson
Comment 4 2016-08-01 10:42:05 PDT
Lots of other Monday-morning work in my queue right now. I'll hold off on landing until much later today.
WebKit Commit Bot
Comment 5 2016-08-01 16:28:28 PDT
Comment on attachment 284888 [details] Patch Rejecting attachment 284888 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 284888, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: hing file Source/WebKit2/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h patching file Source/WebKit2/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.messages.in patching file Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp patching file Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/1794883
Brady Eidson
Comment 6 2016-08-01 21:55:34 PDT
Created attachment 285074 [details] Patch for landing
Carlos Garcia Campos
Comment 7 2016-08-01 22:37:29 PDT
That's a known issue, it has nothing to do with linux, but with cmake based ports I would say and the way we generate the forwarding headers. The thing is that if generated code, like message receivers, uses a WebCore include, we don't generate the forwarding header for that one. The trick is adding that include in the non-generated code where that is needed.
Carlos Garcia Campos
Comment 8 2016-08-01 23:12:26 PDT
Created attachment 285076 [details] Patch for landing
Carlos Garcia Campos
Comment 9 2016-08-01 23:58:59 PDT
Comment on attachment 285076 [details] Patch for landing All green now :-)
Alex Christensen
Comment 10 2016-08-02 00:12:49 PDT
Hooray! Carlos to the rescue! Thanks! *obligatory grumbling about differences in build systems*
WebKit Commit Bot
Comment 11 2016-08-02 00:21:18 PDT
Comment on attachment 285076 [details] Patch for landing Clearing flags on attachment: 285076 Committed r204018: <http://trac.webkit.org/changeset/204018>
Brady Eidson
Comment 12 2016-08-02 09:01:47 PDT
(In reply to comment #10) > Hooray! Carlos to the rescue! Thanks! > *obligatory grumbling about differences in build systems* 👍😞
Note You need to log in before you can comment on or make changes to this bug.