Bug 157424

Summary: Modern IDB (Workers): Start running a lot of the workers tests
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149953    
Attachments:
Description Flags
Patch sam: review+

Brady Eidson
Reported 2016-05-06 12:49:50 PDT
Modern IDB (Workers): Start running a lot of the workers tests There's still plenty of skipped and/or failing tests that show real problems, so the master Workers bug (149953) is not yet done... But we're definitely ready to actually start running basic-to-intermediate tests.
Attachments
Patch (54.07 KB, patch)
2016-05-06 13:00 PDT, Brady Eidson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-05-06 13:00:36 PDT
Created attachment 278260 [details] Patch
WebKit Commit Bot
Comment 2 2016-05-06 13:01:13 PDT
Attachment 278260 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:72: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2016-05-06 13:12:56 PDT
Comment on attachment 278260 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278260&action=review > Source/WebCore/Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp:76 > + if (!RuntimeEnabledFeatures::sharedFeatures().indexedDBWorkersEnabled()) > + return nullptr; This seems like it should be in the bindings.
Brady Eidson
Comment 4 2016-05-06 13:20:49 PDT
(In reply to comment #3) > Comment on attachment 278260 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=278260&action=review > > > Source/WebCore/Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp:76 > > + if (!RuntimeEnabledFeatures::sharedFeatures().indexedDBWorkersEnabled()) > > + return nullptr; > > This seems like it should be in the bindings. It already was, so nm!
Brady Eidson
Comment 5 2016-05-06 14:04:22 PDT
http://trac.webkit.org/changeset/200521
Note You need to log in before you can comment on or make changes to this bug.