Bug 157166

Summary: [css-grid] Update Grid Layout properties in CSSKeywordCompletions.js
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Web InspectorAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, jfernandez, joepeck, mattbaker, nvasilyev, rego, svillar, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch none

Manuel Rego Casasnovas
Reported 2016-04-29 00:16:54 PDT
We should update the grid layout properties in: http://trac.webkit.org/browser/trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js#L779 There're some strange thins like "grid-after" that are no longer in the spec since a lot of time ago. Other new stuff like grid gaps properties are missing.
Attachments
Patch (2.84 KB, patch)
2016-05-09 08:24 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-04-29 00:23:12 PDT
<rdar://problem/25998768>
Manuel Rego Casasnovas
Comment 2 2016-05-09 08:24:37 PDT
Created attachment 278405 [details] Patch
WebKit Commit Bot
Comment 3 2016-05-09 09:08:30 PDT
Comment on attachment 278405 [details] Patch Clearing flags on attachment: 278405 Committed r200575: <http://trac.webkit.org/changeset/200575>
WebKit Commit Bot
Comment 4 2016-05-09 09:08:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.