Bug 155486

Summary: [css-grid] Rename GridResolvedPosition to GridPositionsResolver
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, rego, simon.fraser, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 153488    
Attachments:
Description Flags
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2016-03-15 01:36:27 PDT
We've a TODO in GridResolvedPosition class: // TODO(rego): Rename class to GridPositionsResolver. This was already done in Blink: https://codereview.chromium.org/1648903002/
Attachments
Patch (58.41 KB, patch)
2016-03-15 01:37 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (58.43 KB, patch)
2016-03-15 02:49 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2016-03-15 01:37:59 PDT
Created attachment 274082 [details] Patch
Sergio Villar Senin
Comment 2 2016-03-15 01:47:02 PDT
Comment on attachment 274082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274082&action=review r=me provided all the EWS are happy with the rename > Source/WebCore/rendering/style/GridPositionsResolver.cpp:2 > + * Copyright (C) 2014 Igalia S.L. Let's use this to update the copyright to 2014, 2016 > Source/WebCore/rendering/style/GridPositionsResolver.cpp:38 > +#include <cstdlib> Are we really using this include? > Source/WebCore/rendering/style/GridPositionsResolver.h:2 > + * Copyright (C) 2014 Igalia S.L. Ditto.
Manuel Rego Casasnovas
Comment 3 2016-03-15 02:49:24 PDT
Created attachment 274084 [details] Patch
Manuel Rego Casasnovas
Comment 4 2016-03-15 02:50:34 PDT
Thanks for the review (In reply to comment #2) > > Source/WebCore/rendering/style/GridPositionsResolver.cpp:2 > > + * Copyright (C) 2014 Igalia S.L. > > Let's use this to update the copyright to 2014, 2016 Done. > > > Source/WebCore/rendering/style/GridPositionsResolver.cpp:38 > > +#include <cstdlib> > > Are we really using this include? We need it for std::abs(int). > > Source/WebCore/rendering/style/GridPositionsResolver.h:2 > > + * Copyright (C) 2014 Igalia S.L. > > Ditto. Done.
WebKit Commit Bot
Comment 5 2016-03-15 03:38:30 PDT
Comment on attachment 274084 [details] Patch Clearing flags on attachment: 274084 Committed r198207: <http://trac.webkit.org/changeset/198207>
WebKit Commit Bot
Comment 6 2016-03-15 03:38:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.