Bug 154686

Summary:

Modern IDB: Reimplement Web Inspector code that was tied to Legacy IDB

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

Web Inspector

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

157072

Bug Blocks:

149117

Attachments:

Description	Flags
Patch v1	achristensen: review+, beidson: commit-queue-

Brady Eidson

Reported 2016-02-25 11:56:59 PST

Modern IDB: Reimplement Web Inspector code that was tied to Legacy IDB Modern IDB was enabled for both WK1 and WK2 in http://trac.webkit.org/changeset/197122 The Web Inspector code that relies on Legacy IDB constructs is now dead. It will be pruned further in https://bugs.webkit.org/show_bug.cgi?id=150854 It needs to be reimplemented for Modern IDB.

Attachments
Patch v1 (9.71 KB, patch) 2016-04-27 22:47 PDT, Brady Eidson	achristensen: review+ beidson: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-02-25 11:57:12 PST

<rdar://problem/24842865>

Brady Eidson

Comment 2 2016-04-26 15:12:48 PDT

I'm reimplementing getDatabaseNames now.

Brady Eidson

Comment 3 2016-04-27 09:14:37 PDT

getAllDatabaseNames is just part of this, so I spun it off into its own bug: https://bugs.webkit.org/show_bug.cgi?id=157072

Brady Eidson

Comment 4 2016-04-27 22:47:38 PDT

Created attachment 277594 [details] Patch v1 This patch hooks up all the previous functionality that had been removed in r197131 It gets database info, object store info, and index info, and shows them in the tables off to the side. However, the DataLoader and ClearObjectStore functionality do not work. The reason is that the code doesn't wait for the IDBTransaction created to actually become active. I won't have time to re-architect this to that end.

Brady Eidson

Comment 5 2016-04-28 11:13:23 PDT

(In reply to comment #4) > Created attachment 277594 [details] > > However, the DataLoader and ClearObjectStore functionality do not work. > > The reason is that the code doesn't wait for the IDBTransaction created to > actually become active. This actually seems odd, as transactions are supposed to start out active. I'll look into this outside of this patch landing.

Brady Eidson

Comment 6 2016-04-28 11:45:17 PDT

As EWS shows, this patch was good when uploaded. http://trac.webkit.org/changeset/200192 broke it. I'll update to match then land manually.

Brady Eidson

Comment 7 2016-04-28 11:47:07 PDT

http://trac.webkit.org/changeset/200202

Note You need to log in before you can comment on or make changes to this bug.