Bug 150804

Summary: storage/indexeddb/modern/idbobjectstore-get-failures.html is flaky on mac-wk1
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, commit-queue, jsbell
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Mac   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=150673
Bug Depends on:    
Bug Blocks: 149117    
Attachments:
Description Flags
Patch bdakin: review+

Ryan Haddad
Reported 2015-11-02 09:39:52 PST
storage/indexeddb/modern/idbobjectstore-get-failures.html is flaky on mac-wk1 <https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20%28Tests%29/builds/9598> --- /Volumes/Data/slave/yosemite-release-tests-wk1/build/layout-test-results/storage/indexeddb/modern/idbobjectstore-get-failures-expected.txt +++ /Volumes/Data/slave/yosemite-release-tests-wk1/build/layout-test-results/storage/indexeddb/modern/idbobjectstore-get-failures-actual.txt @@ -2,7 +2,6 @@ ALERT: Failed to get record from object store with an invalid key ALERT: Failed to get record from object store that has been deleted ALERT: Initial upgrade versionchange transaction complete -ALERT: Failed to get record from object store while the transaction is inactive ALERT: readonly transaction complete ALERT: Done This tests some obvious failures that can happen while calling IDBObjectStore.get().
Attachments
Patch (5.41 KB, patch)
2015-11-02 10:36 PST, Brady Eidson 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2015-11-02 09:42:49 PST
Updated expectations in r191890.
Brady Eidson
Comment 2 2015-11-02 10:01:30 PST
While I can't reproduce locally, I'm fairly certain I know what's wrong with the test and have a fix to make it more reliable.
Brady Eidson
Comment 3 2015-11-02 10:31:22 PST
*** Bug 150805 has been marked as a duplicate of this bug. ***
Brady Eidson
Comment 4 2015-11-02 10:31:52 PST
All of the "queue up 10 gets/puts to keep the transaction alive" tests were fundamentally flawed. Fixing them all in one shot.
Brady Eidson
Comment 5 2015-11-02 10:36:52 PST
Created attachment 264599 [details] Patch
Brady Eidson
Comment 6 2015-11-02 10:40:21 PST
https://trac.webkit.org/changeset/191898
Note You need to log in before you can comment on or make changes to this bug.