Bug 149031

Summary: Implement global variables in WebAssembly
Product: WebKit Reporter: Sukolsak Sakshuwong <sukolsak>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mark.lam, saam, sukolsak
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 146064    
Attachments:
Description Flags
Patch
none
Patch none

Sukolsak Sakshuwong
Reported 2015-09-09 22:03:09 PDT
Implement global variables in WebAssembly
Attachments
Patch (18.61 KB, patch)
2015-09-09 22:48 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Patch (18.55 KB, patch)
2015-09-09 22:51 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sukolsak Sakshuwong
Comment 1 2015-09-09 22:48:24 PDT
Created attachment 260911 [details] Patch
Sukolsak Sakshuwong
Comment 2 2015-09-09 22:51:51 PDT
Created attachment 260912 [details] Patch
Geoffrey Garen
Comment 3 2015-09-10 11:29:04 PDT
Comment on attachment 260912 [details] Patch r=me
WebKit Commit Bot
Comment 4 2015-09-10 12:34:51 PDT
Comment on attachment 260912 [details] Patch Clearing flags on attachment: 260912 Committed r189584: <http://trac.webkit.org/changeset/189584>
WebKit Commit Bot
Comment 5 2015-09-10 12:34:55 PDT
All reviewed patches have been landed. Closing bug.
Sukolsak Sakshuwong
Comment 6 2015-09-22 03:46:47 PDT
Global variables have been removed from the MVP. "Mutable global variables In the MVP, there are no global variables; C/C++ global variables are stored in linear memory and thus accessed through normal linear memory operations. Dynamic linking will add some form of immutable global variable analogous to "symbols" in native binaries. In some cases, though, it may be useful to have a fully mutable global variable which lives outside linear memory. This would allow more aggressive compiler optimizations (due to better alias information). If globals are additionally allowed array types, significant portions of memory could be moved out of linear memory which could reduce fragmentation issues. Langauges like FORTRAN which limit aliasing would be one use case. C/C++ compilers could also determine that some global variables never have their address taken." (https://github.com/WebAssembly/design/blob/master/FutureFeatures.md#mutable-global-variables) "Postpone adding globals until dynamic linking" (https://github.com/WebAssembly/design/issues/154)
Note You need to log in before you can comment on or make changes to this bug.