Bug 146061

Summary: [CSS Grid Layout] Performance tests are using the old syntax
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: Layout and RenderingAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, rego, rniwa, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 127987    
Attachments:
Description Flags
Patch none

Javier Fernandez
Reported 2015-06-17 07:57:14 PDT
Somehow we forgot to update the Grid Layout performance tests when tracks definition syntax changed. Currently they are using grid-definition-{rows, columns} instead if what current official draft is specifying, grid-template-{rows, columns}.
Attachments
Patch (1.99 KB, patch)
2015-06-17 08:01 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2015-06-17 08:01:08 PDT
Created attachment 255015 [details] Patch
Sergio Villar Senin
Comment 2 2015-06-17 08:25:16 PDT
Comment on attachment 255015 [details] Patch What a mistake! Nice catch!
WebKit Commit Bot
Comment 3 2015-06-17 09:14:31 PDT
Comment on attachment 255015 [details] Patch Clearing flags on attachment: 255015 Committed r185652: <http://trac.webkit.org/changeset/185652>
WebKit Commit Bot
Comment 4 2015-06-17 09:14:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.