Bug 146011

Summary:

AX: Add ARIA 1.1 "cell" and "table" roles

Product:

WebKit

Reporter:

James Craig <jcraig>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, bfulgham, buildbot, cfleizach, clopez, commit-queue, dmazzoni, jdiggs, mario, n_wang, rniwa, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

146887

Bug Blocks:

136415

Attachments:

Description	Flags
patch	none
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Archive of layout-test-results from ews101 for mac-mavericks	none
patch to fix mavericks' test expectation	none
patch to fix computedRoleString test	none
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
patch that fixed test expectation	none
patch with windows test expectation	cfleizach: review+, cfleizach: commit-queue+

James Craig

Reported 2015-06-16 02:05:32 PDT

> The new roles can be found here: > https://rawgit.com/w3c/aria/master/aria/aria.html#cell > https://rawgit.com/w3c/aria/master/aria/aria.html#table I don't think WebKit has special behavior for the interactive portion of the grid and gridcell roles, so these can probably be aliases for now. computedRoleString should be updated to use the static variants, too.

Attachments
patch (19.27 KB, patch) 2015-07-10 09:35 PDT, Nan Wang	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (591.10 KB, application/zip) 2015-07-10 10:15 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-mavericks (551.60 KB, application/zip) 2015-07-10 10:28 PDT, Build Bot	no flags	Details
patch to fix mavericks' test expectation (20.80 KB, patch) 2015-07-10 11:36 PDT, Nan Wang	no flags	Details Formatted Diff Diff
patch to fix computedRoleString test (21.77 KB, patch) 2015-07-10 12:17 PDT, Nan Wang	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (530.75 KB, application/zip) 2015-07-10 12:52 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (573.77 KB, application/zip) 2015-07-10 12:56 PDT, Build Bot	no flags	Details
patch that fixed test expectation (22.49 KB, patch) 2015-07-10 13:32 PDT, Nan Wang	no flags	Details Formatted Diff Diff
patch with windows test expectation (2.15 KB, patch) 2015-07-13 16:01 PDT, Nan Wang	cfleizach: review+ cfleizach: commit-queue+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-06-16 02:06:46 PDT

<rdar://problem/21398946>

Nan Wang

Comment 2 2015-07-10 09:35:58 PDT

Created attachment 256581 [details] patch

Build Bot

Comment 3 2015-07-10 10:14:55 PDT

Comment on attachment 256581 [details] patch Attachment 256581 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6466871326932992 New failing tests: accessibility/roles-exposed.html accessibility/aria-table-with-presentational-elements.html

Build Bot

Comment 4 2015-07-10 10:15:00 PDT

Created attachment 256583 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 5 2015-07-10 10:28:29 PDT

Comment on attachment 256581 [details] patch Attachment 256581 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5021898299670528 New failing tests: accessibility/roles-exposed.html accessibility/aria-table-with-presentational-elements.html

Build Bot

Comment 6 2015-07-10 10:28:33 PDT

Created attachment 256586 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Nan Wang

Comment 7 2015-07-10 11:36:33 PDT

Created attachment 256598 [details] patch to fix mavericks' test expectation

chris fleizach

Comment 8 2015-07-10 11:42:59 PDT

Comment on attachment 256598 [details] patch to fix mavericks' test expectation we only need the patch for just the new things

Nan Wang

Comment 9 2015-07-10 12:17:19 PDT

Created attachment 256600 [details] patch to fix computedRoleString test

Build Bot

Comment 10 2015-07-10 12:52:19 PDT

Comment on attachment 256600 [details] patch to fix computedRoleString test Attachment 256600 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5889576182743040 New failing tests: accessibility/aria-table-with-presentational-elements.html

Build Bot

Comment 11 2015-07-10 12:52:23 PDT

Created attachment 256602 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 12 2015-07-10 12:56:40 PDT

Comment on attachment 256600 [details] patch to fix computedRoleString test Attachment 256600 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4689070546485248 New failing tests: accessibility/aria-table-with-presentational-elements.html

Build Bot

Comment 13 2015-07-10 12:56:44 PDT

Created attachment 256603 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Nan Wang

Comment 14 2015-07-10 13:32:46 PDT

Created attachment 256606 [details] patch that fixed test expectation

WebKit Commit Bot

Comment 15 2015-07-10 15:05:58 PDT

Comment on attachment 256606 [details] patch that fixed test expectation Clearing flags on attachment: 256606 Committed r186692: <http://trac.webkit.org/changeset/186692>

WebKit Commit Bot

Comment 16 2015-07-10 15:06:04 PDT

All reviewed patches have been landed. Closing bug.

Brent Fulgham

Comment 17 2015-07-13 09:31:35 PDT

These tests fail on Windows. Can you please add a skip for them and file a bug to implement the missing features?

Carlos Alberto Lopez Perez

Comment 18 2015-07-13 14:09:38 PDT

(In reply to comment #17) > These tests fail on Windows. Can you please add a skip for them and file a > bug to implement the missing features? They fail also for GTK.

Nan Wang

Comment 19 2015-07-13 14:13:30 PDT

(In reply to comment #17) > These tests fail on Windows. Can you please add a skip for them and file a > bug to implement the missing features? I'll be working on adding new expectations for not working platforms.

Nan Wang

Comment 20 2015-07-13 16:01:54 PDT

Created attachment 256740 [details] patch with windows test expectation

Note You need to log in before you can comment on or make changes to this bug.