Bug 139085

Summary: [EFL] Add a ENABLE_CSS_SCROLL_SNAP macro to CMake build system
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 139083    
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2014-11-27 23:03:13 PST
There is a build break when it is enabled. To fix it, EFL port needs to include page/scrolling/AxisScrollSnapOffsets.cpp.
Attachments
Patch (4.29 KB, patch)
2014-11-27 23:08 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-11-27 23:04:29 PST
(In reply to comment #0) > There is a build break when it is enabled. To fix it, EFL port needs to > include page/scrolling/AxisScrollSnapOffsets.cpp. I change bug title, This bug will fix build break as well.
Gyuyoung Kim
Comment 2 2014-11-27 23:04:29 PST
(In reply to comment #0) > There is a build break when it is enabled. To fix it, EFL port needs to > include page/scrolling/AxisScrollSnapOffsets.cpp. I change bug title, This bug will fix build break as well.
Gyuyoung Kim
Comment 3 2014-11-27 23:08:24 PST
Created attachment 242262 [details] Patch
Gyuyoung Kim
Comment 4 2014-11-29 00:39:30 PST
CC'ing Ossy.
Andreas Kling
Comment 5 2014-12-01 17:13:35 PST
Comment on attachment 242262 [details] Patch r=me
WebKit Commit Bot
Comment 6 2014-12-01 18:02:31 PST
Comment on attachment 242262 [details] Patch Clearing flags on attachment: 242262 Committed r176620: <http://trac.webkit.org/changeset/176620>
WebKit Commit Bot
Comment 7 2014-12-01 18:02:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.