Bug 125730

Summary: cStack: Crypto crashes in GC
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, cmarcelo, commit-queue, fpizlo, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 113621    
Attachments:
Description Flags
the version of Crypto I use
none
Patch fpizlo: review+

Filip Pizlo
Reported 2013-12-13 21:04:42 PST
...
Attachments
the version of Crypto I use (56.35 KB, text/plain)
2013-12-13 21:05 PST, Filip Pizlo 		no flags
Details
Patch (4.23 KB, patch)
2013-12-13 22:43 PST, Michael Saboff 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-12-13 21:05:16 PST
Created attachment 219230 [details] the version of Crypto I use
Michael Saboff
Comment 2 2013-12-13 22:43:47 PST
Created attachment 219241 [details] Patch
Filip Pizlo
Comment 3 2013-12-13 22:46:55 PST
Comment on attachment 219241 [details] Patch I would get rid of the new USE macro as just use LLINT_CLOOP directly. They are exactly equivalent anyway.
Michael Saboff
Comment 4 2013-12-13 22:50:20 PST
(In reply to comment #3) > (From update of attachment 219241 [details]) > I would get rid of the new USE macro as just use LLINT_CLOOP directly. They are exactly equivalent anyway. Mark Lam recently added the WTF_USE_SEPARATE_C_AND_JS_STACK macro. I'd like to handle that in another patch.
Michael Saboff
Comment 5 2013-12-13 23:15:48 PST
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 219241 [details] [details]) > > I would get rid of the new USE macro as just use LLINT_CLOOP directly. They are exactly equivalent anyway. > > Mark Lam recently added the WTF_USE_SEPARATE_C_AND_JS_STACK macro. I'd like to handle that in another patch. Tracked in https://bugs.webkit.org/show_bug.cgi?id=125733 - "CStack Branch: Remove WTF_USE_SEPARATE_C_AND_JS_STACK"
Michael Saboff
Comment 6 2013-12-13 23:15:58 PST
Committed r160589: <http://trac.webkit.org/changeset/160589>
Note You need to log in before you can comment on or make changes to this bug.