Bug 124737

Summary: Web Inspector: [CSS Shapes] Refactor highlighting code to decrease Shapes API surface
Product: WebKit Reporter: Bear Travis <betravis>
Component: Web InspectorAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, graouts, joepeck, kondapallykalyan, timothy, webkit-bug-importer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 124070    
Attachments:
Description Flags
Initial patch
timothy: review+
Renaming buildInspectorPath to buildPath none

Bear Travis
Reported 2013-11-21 12:34:46 PST
The descendants of the Shapes class have to expose some internal workings in order to build the paths for the inspector highlights. A cleaner implementation would just pass a path or data struct in to the shape to be populated.
Attachments
Initial patch (17.71 KB, patch)
2013-11-21 12:49 PST, Bear Travis 		timothy: review+
DetailsFormatted DiffDiff
Renaming buildInspectorPath to buildPath (16.74 KB, patch)
2013-11-21 16:15 PST, Bear Travis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2013-11-21 12:49:40 PST
Created attachment 217602 [details] Initial patch
Bear Travis
Comment 2 2013-11-21 16:15:17 PST
Created attachment 217624 [details] Renaming buildInspectorPath to buildPath
WebKit Commit Bot
Comment 3 2013-11-21 19:14:50 PST
Comment on attachment 217624 [details] Renaming buildInspectorPath to buildPath Clearing flags on attachment: 217624 Committed r159671: <http://trac.webkit.org/changeset/159671>
WebKit Commit Bot
Comment 4 2013-11-21 19:14:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.