Bug 122251

Summary: [CSS Shapes] Revise the CSS property parsing tests
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Hans Muller
Reported 2013-10-02 17:27:02 PDT
akling pointed out that we should flatten the CSS Shape property parsing tests a little by hoisting the scripts into the HTML files. See https://bugs.webkit.org/show_bug.cgi?id=122216#c2
Attachments
Patch (45.70 KB, patch)
2013-10-03 12:13 PDT, Hans Muller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2013-10-03 12:13:10 PDT
Created attachment 213286 [details] Patch Flattened the shapes CSS property parsing tests by inserting the code from the fast/shapes/parsing/script-tests subdirectory into the test HTML source files. The subdirectory is now empty and the tests are easier to read.
Andreas Kling
Comment 2 2013-10-03 12:31:28 PDT
Comment on attachment 213286 [details] Patch Awesome! r=me
WebKit Commit Bot
Comment 3 2013-10-03 12:59:29 PDT
Comment on attachment 213286 [details] Patch Clearing flags on attachment: 213286 Committed r156851: <http://trac.webkit.org/changeset/156851>
WebKit Commit Bot
Comment 4 2013-10-03 12:59:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.