Bug 118386

Summary: [GTK] Leak: Free PangoFontDescription* in RenderThemeGtk3
Product: WebKit Reporter: Brian Holt <brian.holt>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, kling, menard, mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 116317    
Attachments:
Description Flags
Patch none

Brian Holt
Reported 2013-07-04 01:52:49 PDT
Leaks found using the "--leak" option in the Gtk port: Command: /home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/Programs/DumpRenderTree - Leak_DefinitelyLost 337 (289 direct, 48 indirect) bytes in 23 blocks are definitely lost in loss record 603 of 913 malloc (/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) g_malloc (/WebKitBuild/Dependencies/Source/glib-2.36.0/glib/gmem.c:159) g_slice_alloc (/WebKitBuild/Dependencies/Source/glib-2.36.0/glib/gslice.c:1003) pango_font_description_copy (/build/buildd/pango1.0-1.30.1/./pango/fonts.c:675) boxed_proxy_lcopy_value (/WebKitBuild/Dependencies/Source/glib-2.36.0/gobject/gboxed.c:266) gtk_style_context_get_valist (/WebKitBuild/Dependencies/Source/gtk+-3.6.0/gtk/gtkstylecontext.c:1437) gtk_style_context_get (/WebKitBuild/Dependencies/Source/gtk+-3.6.0/gtk/gtkstylecontext.c:1472) WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle(WebCore::StyleResolver*, WebCore::RenderStyle*, WebCore::Element*) const (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::RenderTheme::adjustStyle(WebCore::StyleResolver*, WebCore::RenderStyle*, WebCore::Element*, bool, WebCore::BorderData const&, WebCore::FillLayer const&, WebCore::Color const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::StyleResolver::adjustRenderStyle(WebCore::RenderStyle*, WebCore::RenderStyle*, WebCore::Element*) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::StyleResolver::styleForElement(WebCore::Element*, WebCore::RenderStyle*, WebCore::StyleSharingBehavior, WebCore::RuleMatchingBehavior, WebCore::RenderRegion*) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::Element::styleForRenderer() (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::NodeRenderingContext::createRendererForElementIfNeeded() (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::Element::createRendererIfNeeded(WebCore::Node::AttachContext const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::Element::attach(WebCore::Node::AttachContext const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::ContainerNode::attach(WebCore::Node::AttachContext const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::Element::attach(WebCore::Node::AttachContext const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::ContainerNode::attach(WebCore::Node::AttachContext const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::ShadowRoot::attach(WebCore::Node::AttachContext const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::ElementShadow::attach(WebCore::Node::AttachContext const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::Element::attach(WebCore::Node::AttachContext const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLFormControlElement::attach(WebCore::Node::AttachContext const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLInputElement::attach(WebCore::Node::AttachContext const&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLConstructionSite::executeQueuedTasks() (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLDocumentParser::constructTreeFromHTMLToken(WebCore::HTMLToken&) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution() (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::HTMLDocumentParser::notifyFinished(WebCore::CachedResource*) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::CachedResource::checkNotify() (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) WebCore::SubresourceLoader::didFinishLoading(double) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1) Suppression (error hash=#0745ED00D4761028#): For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports { <insert_a_suppression_name_here> Memcheck:Leak fun:malloc fun:g_malloc fun:g_slice_alloc fun:pango_font_description_copy fun:boxed_proxy_lcopy_value fun:gtk_style_context_get_valist fun:gtk_style_context_get fun:_ZNK7WebCore14RenderThemeGtk26adjustInnerSpinButtonStyleEPNS_13StyleResolverEPNS_11RenderStyleEPNS_7ElementE fun:_ZN7WebCore11RenderTheme11adjustStyleEPNS_13StyleResolverEPNS_11RenderStyleEPNS_7ElementEbRKNS_10BorderDataERKNS_9FillLayerERKNS_5ColorE fun:_ZN7WebCore13StyleResolver17adjustRenderStyleEPNS_11RenderStyleES2_PNS_7ElementE fun:_ZN7WebCore13StyleResolver15styleForElementEPNS_7ElementEPNS_11RenderStyleENS_20StyleSharingBehaviorENS_20RuleMatchingBehaviorEPNS_12RenderRegionE fun:_ZN7WebCore7Element16styleForRendererEv fun:_ZN7WebCore20NodeRenderingContext32createRendererForElementIfNeededEv fun:_ZN7WebCore7Element22createRendererIfNeededERKNS_4Node13AttachContextE fun:_ZN7WebCore7Element6attachERKNS_4Node13AttachContextE fun:_ZN7WebCore13ContainerNode6attachERKNS_4Node13AttachContextE fun:_ZN7WebCore7Element6attachERKNS_4Node13AttachContextE fun:_ZN7WebCore13ContainerNode6attachERKNS_4Node13AttachContextE fun:_ZN7WebCore10ShadowRoot6attachERKNS_4Node13AttachContextE fun:_ZN7WebCore13ElementShadow6attachERKNS_4Node13AttachContextE fun:_ZN7WebCore7Element6attachERKNS_4Node13AttachContextE fun:_ZN7WebCore22HTMLFormControlElement6attachERKNS_4Node13AttachContextE }
Attachments
Patch (1.65 KB, patch)
2013-07-04 04:52 PDT, Brian Holt 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Holt
Comment 1 2013-07-04 04:52:43 PDT
Created attachment 206076 [details] Patch
Carlos Garcia Campos
Comment 2 2013-07-04 05:15:36 PDT
Comment on attachment 206076 [details] Patch Thanks!
WebKit Commit Bot
Comment 3 2013-07-04 06:18:58 PDT
Comment on attachment 206076 [details] Patch Clearing flags on attachment: 206076 Committed r152398: <http://trac.webkit.org/changeset/152398>
WebKit Commit Bot
Comment 4 2013-07-04 06:19:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.