Bug 118351

Summary: Have SVGTextContentElement inherit SVGGraphicsElement
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: SVGAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, d-r, esprehn+autocc, fmalita, krit, laszlo.gombos, pdr, rniwa, schenney, zimmermann
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: https://svgwg.org/svg2-draft/text.html#InterfaceSVGTextContentElement
Bug Depends on:    
Bug Blocks: 118353    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-07-03 03:54:07 PDT
Have SVGTextContentElement inherit SVGGraphicsElement instead of SVGStyledElement in order to match the latest SVG2 specification: https://svgwg.org/svg2-draft/text.html#InterfaceSVGTextContentElement This patch also removes the SVGTransformable and SVGLocatable IDL interfaces as they are no longer needed (were merged into SVGGraphicsElement in the latest specification). Conversion to absolute (user agent) coordinates in the svg/text tests is fixed to use SVGGraphicsElement::getScreenCTM() instead of SVGGraphicsElement::getTransformToElement(). The previous code was working until now due to a bug in getTransformToElement(), which was not taking into consideration the CTM of the SVGTextElement (as it was not recognized as a "locatable" element). Now that SVGTextElement inherits from SVGGraphicsElement, it is properly recognized as a "locatable" element by getTransformToElement(). This is one step towards getting rid of multiple inheritance in SVG and matching the latest SVG2 specification. Corresponding Blink revision: https://src.chromium.org/viewvc/blink?view=rev&revision=153432
Attachments
Patch (30.48 KB, patch)
2013-07-03 04:21 PDT, Chris Dumez
no flags
Chris Dumez
Comment 1 2013-07-03 04:21:53 PDT
Dirk Schulze
Comment 2 2013-07-04 11:26:17 PDT
Comment on attachment 205991 [details] Patch r=me
WebKit Commit Bot
Comment 3 2013-07-04 11:49:35 PDT
Comment on attachment 205991 [details] Patch Clearing flags on attachment: 205991 Committed r152404: <http://trac.webkit.org/changeset/152404>
WebKit Commit Bot
Comment 4 2013-07-04 11:49:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.