Bug 113541

Summary:

[HTMLTemplateElement] <template> should be able to be a foster parent

Product:

WebKit

Reporter:

Rafael Weinstein <rafaelw>

Component:

DOM

Assignee:

Rafael Weinstein <rafaelw>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, adamk, eric, esprehn+autocc, ojan.autocc, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

103547

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from gce-cq-01 for chromium-linux-x86_64	none
Patch for landing	none

Rafael Weinstein

Reported 2013-03-28 15:43:48 PDT

e.g. <template><table>Foo 'Foo' will get foster-parented and, per the spec, "The foster parent element is the parent element of the last table element in the stack of open elements, if there is a table element and it has such a parent element". In this case, the <template> is that parent element.

Attachments
Patch (3.38 KB, patch) 2013-03-28 15:45 PDT, Rafael Weinstein	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cq-01 for chromium-linux-x86_64 (1.37 MB, application/zip) 2013-03-28 16:45 PDT, WebKit Review Bot	no flags	Details
Patch for landing (3.38 KB, patch) 2013-03-28 16:50 PDT, Rafael Weinstein	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Rafael Weinstein

Comment 1 2013-03-28 15:45:59 PDT

Created attachment 195663 [details] Patch

Eric Seidel (no email)

Comment 2 2013-03-28 15:55:22 PDT

Comment on attachment 195663 [details] Patch OK.

WebKit Review Bot

Comment 3 2013-03-28 16:45:00 PDT

Comment on attachment 195663 [details] Patch Rejecting attachment 195663 [details] from commit-queue. New failing tests: fast/parser/remove-current-node-parent.html Full output: http://webkit-commit-queue.appspot.com/results/17359021

WebKit Review Bot

Comment 4 2013-03-28 16:45:03 PDT

Created attachment 195678 [details] Archive of layout-test-results from gce-cq-01 for chromium-linux-x86_64 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: gce-cq-01 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

Rafael Weinstein

Comment 5 2013-03-28 16:50:27 PDT

Created attachment 195680 [details] Patch for landing

Rafael Weinstein

Comment 6 2013-03-28 16:50:54 PDT

needed null check in both places. fixed.

WebKit Review Bot

Comment 7 2013-03-28 17:11:23 PDT

Comment on attachment 195680 [details] Patch for landing Clearing flags on attachment: 195680 Committed r147185: <http://trac.webkit.org/changeset/147185>

WebKit Review Bot

Comment 8 2013-03-28 17:11:27 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.