Bug 112866

Summary: [Shadow] Provide an api of insertionParent().
Product: WebKit Reporter: Hayato Ito <hayato>
Component: DOMAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, esprehn+autocc, ojan.autocc, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63606    
Attachments:
Description Flags
let me watch the result of ews none

Hayato Ito
Reported 2013-03-20 18:57:42 PDT
This is a bug in WebKit side. The spec is here: https://www.w3.org/Bugs/Public/show_bug.cgi?id=21067
Attachments
let me watch the result of ews (7.62 KB, patch)
2013-03-21 03:43 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2013-03-21 03:43:49 PDT
Created attachment 194218 [details] let me watch the result of ews
Dimitri Glazkov (Google)
Comment 2 2013-03-21 09:36:43 PDT
Comment on attachment 194218 [details] let me watch the result of ews View in context: https://bugs.webkit.org/attachment.cgi?id=194218&action=review > Source/WebCore/dom/Node.cpp:1277 > +Node* Node::insertionParentForBinding() const is ForBinding the common pattern we use for these things?
Hayato Ito
Comment 3 2013-03-21 19:35:02 PDT
Thank you for the review. Let me land this. (In reply to comment #2) > (From update of attachment 194218 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=194218&action=review > > > Source/WebCore/dom/Node.cpp:1277 > > +Node* Node::insertionParentForBinding() const > > is ForBinding the common pattern we use for these things? I am not sure this is the common patter. I could not find the convention. I'm totally okay to change the name if we find a good convention.
WebKit Review Bot
Comment 4 2013-03-21 20:02:25 PDT
Comment on attachment 194218 [details] let me watch the result of ews Clearing flags on attachment: 194218 Committed r146555: <http://trac.webkit.org/changeset/146555>
WebKit Review Bot
Comment 5 2013-03-21 20:02:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.