Bug 110450

Summary:

[EFL][Qt][WK2] Don't use delegates scrolling and fixed visible content rect.

Product:

WebKit

Reporter:

Dongseong Hwang <dongseong.hwang>

Component:

Layout and Rendering

Assignee:

Dongseong Hwang <dongseong.hwang>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abecsi, allan.jensen, buildbot, cmarcelo, dglazkov, eric, esprehn+autocc, gyuyoung.kim, jturcotte, kenneth, luiz, mcatanzaro, menard, mikhail.pozdnyakov, noam, ojan.autocc, rakuco, rniwa, simon.fraser, webkit.review.bot, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

110298

Bug Blocks:

110066

Attachments:

Description	Flags
WIP: share to show the direction	none
WIP by 80%. I'll separate this big changes into several bugs.	none
WIP by 95%. I'll separate this big changes into several bugs.	buildbot: commit-queue-

Dongseong Hwang

Reported 2013-02-21 03:01:50 PST

SSIA

Attachments
WIP: share to show the direction (23.33 KB, patch) 2013-02-21 03:05 PST, Dongseong Hwang	no flags	Details Formatted Diff Diff
WIP by 80%. I'll separate this big changes into several bugs. (89.13 KB, patch) 2013-02-26 22:13 PST, Dongseong Hwang	no flags	Details Formatted Diff Diff
WIP by 95%. I'll separate this big changes into several bugs. (111.06 KB, patch) 2013-03-04 01:22 PST, Dongseong Hwang	buildbot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dongseong Hwang

Comment 1 2013-02-21 03:05:13 PST

Created attachment 189494 [details] WIP: share to show the direction

Noam Rosenthal

Comment 2 2013-02-21 03:06:57 PST

changelog?

Dongseong Hwang

Comment 3 2013-02-21 03:08:19 PST

To clarify the objective, I copy and paste words from Bug 110066 Kenneth raised a question that we still need to use ScrollView::m_fixedVisibleContentRect. Currently, we used fixedVisibleContentRect to make WebCore know actual scroll position and viewport size that PageViewportController deals with. After Bug 105978 and Bug 107424, ScrollView can trace actual viewport size of PageViewportController. So if we make ScrollView know actual scroll position, we can remove fixedVisibleContentRect as well as delegates scrolling. This huge changes have benefits as follow: 1. We share more code with other ports 2. It would be an intermediate step to go with scrolling coordinator (AFAIK cmarcelo and MPozdnyakov are investigating)

Dongseong Hwang

Comment 4 2013-02-21 03:08:48 PST

(In reply to comment #2) > changelog? I'll write. I'm working in progress :)

Noam Rosenthal

Comment 5 2013-02-21 03:09:27 PST

(In reply to comment #4) > (In reply to comment #2) > > changelog? > > I'll write. I'm working in progress :) np :)

Kenneth Rohde Christiansen

Comment 6 2013-02-21 03:16:24 PST

Comment on attachment 189494 [details] WIP: share to show the direction OK, I see this is getting somewhere!

Build Bot

Comment 7 2013-02-21 03:51:49 PST

Comment on attachment 189494 [details] WIP: share to show the direction Attachment 189494 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16651967 New failing tests: compositing/iframes/become-composited-nested-iframes.html compositing/iframes/invisible-nested-iframe-show.html

Dongseong Hwang

Comment 8 2013-02-21 21:36:00 PST

(In reply to comment #5) > np :) (In reply to comment #6) > (From update of attachment 189494 [details]) > OK, I see this is getting somewhere! hehe. give me time :)

Dongseong Hwang

Comment 9 2013-02-26 22:13:30 PST

Created attachment 190442 [details] WIP by 80%. I'll separate this big changes into several bugs.

Andras Becsi

Comment 10 2013-02-28 08:49:09 PST

Comment on attachment 190442 [details] WIP by 80%. I'll separate this big changes into several bugs. View in context: https://bugs.webkit.org/attachment.cgi?id=190442&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:187 > +QTransform QQuickWebPage::transformFromItemToWebView() const > +{ > + return transformFromWebViewToItem().inverted(); > +} > + > +QTransform QQuickWebPage::transformFromWebViewToItem() const > +{ > + qreal xPos = x(); > + qreal yPos = y(); > + > + return QTransform(d->contentsScale, 0, 0, 0, d->contentsScale, 0, xPos, yPos, 1); > +} I suspect this breaks event transformation if the WebView has other items anchored to the content qquickwebpage. Why is this change needed?

Dongseong Hwang

Comment 11 2013-03-04 01:20:41 PST

(In reply to comment #10) > (From update of attachment 190442 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=190442&action=review > I suspect this breaks event transformation if the WebView has other items anchored to the content qquickwebpage. > Why is this change needed? Thank you for noting. This part was separated in Bug 109033. In Bug 109033, I change as follows : QPointF scrollPosition = transformFromItem().map(QPointF()); node->setScrollPosition(scrollPosition); Could you check if I correct? :)

Dongseong Hwang

Comment 12 2013-03-04 01:22:45 PST

Created attachment 191171 [details] WIP by 95%. I'll separate this big changes into several bugs. WIP by 95%. I'll separate this big changes into several bugs.

WebKit Review Bot

Comment 13 2013-03-04 01:24:58 PST

Attachment 191171 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/efl-wk2/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt', u'LayoutTests/platform/efl-wk2/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt', u'LayoutTests/platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt', u'LayoutTests/platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp', u'Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/NativeWebTouchEvent.h', u'Source/WebKit2/Shared/NativeWebWheelEvent.h', u'Source/WebKit2/Shared/efl/NativeWebMouseEventEfl.cpp', u'Source/WebKit2/Shared/efl/NativeWebTouchEventEfl.cpp', u'Source/WebKit2/Shared/efl/NativeWebWheelEventEfl.cpp', u'Source/WebKit2/Shared/efl/WebEventFactory.cpp', u'Source/WebKit2/UIProcess/API/efl/EwkView.cpp', u'Source/WebKit2/UIProcess/API/efl/EwkView.h', u'Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp', u'Source/WebKit2/UIProcess/API/qt/qquickwebpage_p.h', u'Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp', u'Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h', u'Source/WebKit2/UIProcess/API/qt/raw/qrawwebview.cpp', u'Source/WebKit2/UIProcess/API/qt/raw/qrawwebview_p_p.h', u'Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp', u'Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h', u'Source/WebKit2/UIProcess/DrawingAreaProxy.h', u'Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp', u'Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h', u'Source/WebKit2/UIProcess/PageClient.h', u'Source/WebKit2/UIProcess/PageViewportController.cpp', u'Source/WebKit2/UIProcess/PageViewportController.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.cpp', u'Source/WebKit2/UIProcess/efl/WebView.cpp', u'Source/WebKit2/UIProcess/efl/WebView.h', u'Source/WebKit2/UIProcess/qt/PageViewportControllerClientQt.cpp', u'Source/WebKit2/UIProcess/qt/PageViewportControllerClientQt.h', u'Source/WebKit2/UIProcess/qt/QtPageClient.cpp', u'Source/WebKit2/UIProcess/qt/QtPageClient.h', u'Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp', u'Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp', u'Source/WebKit2/UIProcess/qt/QtWebPageSGNode.h', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp', u'Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h', u'Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in', u'Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp', u'Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.messages.in', u'Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.h', u'Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h', u'Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm']" exit_code: 1 Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:227: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 54 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 14 2013-03-04 01:56:15 PST

Comment on attachment 191171 [details] WIP by 95%. I'll separate this big changes into several bugs. Attachment 191171 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/16916184

Build Bot

Comment 15 2013-03-04 02:14:00 PST

Comment on attachment 191171 [details] WIP by 95%. I'll separate this big changes into several bugs. Attachment 191171 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/16898780

Andras Becsi

Comment 16 2013-03-04 03:10:39 PST

(In reply to comment #11) > (In reply to comment #10) > > (From update of attachment 190442 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=190442&action=review > > I suspect this breaks event transformation if the WebView has other items anchored to the content qquickwebpage. > > Why is this change needed? > > Thank you for noting. This part was separated in Bug 109033. > > In Bug 109033, I change as follows : > QPointF scrollPosition = transformFromItem().map(QPointF()); > node->setScrollPosition(scrollPosition); > > Could you check if I correct? :) Thanks, I think that should work.

WebKit Review Bot

Comment 17 2013-03-05 01:43:53 PST

Comment on attachment 191171 [details] WIP by 95%. I'll separate this big changes into several bugs. Attachment 191171 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17025064 New failing tests: compositing/iframes/nested-composited-iframe.html compositing/iframes/overlapped-nested-iframes.html platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed.html platform/chromium/virtual/softwarecompositing/framesets/composited-frame-alignment.html compositing/framesets/composited-frame-alignment.html compositing/iframes/invisible-nested-iframe-show.html platform/chromium/virtual/softwarecompositing/iframes/invisible-nested-iframe-show.html platform/chromium/virtual/softwarecompositing/iframes/overlapped-nested-iframes.html platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute.html platform/chromium/virtual/softwarecompositing/iframes/become-composited-nested-iframes.html platform/chromium/virtual/softwarecompositing/iframes/nested-composited-iframe.html compositing/iframes/become-composited-nested-iframes.html platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative.html

Michael Catanzaro

Comment 18 2017-03-11 10:39:29 PST

Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.

Note You need to log in before you can comment on or make changes to this bug.